Message ID | 20100221142320.GP14767@redhat.com |
---|---|
State | New |
Headers | show |
Gleb Natapov <gleb@redhat.com> writes: > It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical) > when env is true. > > Signed-off-by: Gleb Natapov <gleb@redhat.com> > diff --git a/monitor.c b/monitor.c > index b1a6edc..19470d1 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, > int flags; > flags = 0; > env = mon_get_cpu(); > - if (!is_physical) > - return; > #ifdef TARGET_I386 > if (wsize == 2) { > flags = 1; *Ouch* I checked the offending commit for more such errors, but couldn't find any.
diff --git a/monitor.c b/monitor.c index b1a6edc..19470d1 100644 --- a/monitor.c +++ b/monitor.c @@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, int flags; flags = 0; env = mon_get_cpu(); - if (!is_physical) - return; #ifdef TARGET_I386 if (wsize == 2) { flags = 1;
It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical) when env is true. Signed-off-by: Gleb Natapov <gleb@redhat.com> -- Gleb.