From patchwork Thu Jan 14 03:09:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 42845 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5CB16B7C7E for ; Thu, 14 Jan 2010 14:12:31 +1100 (EST) Received: from localhost ([127.0.0.1]:48656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVG7i-0000Gn-0T for incoming@patchwork.ozlabs.org; Wed, 13 Jan 2010 22:11:50 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVG6b-0000Gi-AH for qemu-devel@nongnu.org; Wed, 13 Jan 2010 22:10:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVG6W-0000GW-Aa for qemu-devel@nongnu.org; Wed, 13 Jan 2010 22:10:40 -0500 Received: from [199.232.76.173] (port=53477 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVG6W-0000GT-5r for qemu-devel@nongnu.org; Wed, 13 Jan 2010 22:10:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5206) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NVG6V-00084d-PS for qemu-devel@nongnu.org; Wed, 13 Jan 2010 22:10:36 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0E3AVaY012947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jan 2010 22:10:32 -0500 Received: from localhost (vpn-246-68.phx2.redhat.com [10.3.246.68]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0E3ATXJ012006; Wed, 13 Jan 2010 22:10:30 -0500 Date: Thu, 14 Jan 2010 08:39:24 +0530 From: Amit Shah To: Blue Swirl Subject: Re: [Qemu-devel] Static analysis using clang on the x86_64 target Message-ID: <20100114030924.GF24002@amit-x200.redhat.com> References: <20100112181307.GD19438@amit-x200.redhat.com> <20100113070254.GD31063@amit-x200.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On (Wed) Jan 13 2010 [19:08:11], Blue Swirl wrote: > > Thanks. I fixed the warnings related to Sparc32. Were there really no > new warnings for Sparc64? Looks like it; vl.c gets reported three times at the same locations so 3 arches have been compiled. My test machine is down ATM, I can confirm later when it's up. BTW for the patch commit 884a0c7677cf8431d2a632673914994c2e01673d pcnet: remove dead nested assignment, spotted by clang #endif if debugging is enabled, addr will now print a different value than earlier. Amit diff --git a/hw/pcnet.c b/hw/pcnet.c index 91d106d..44b5b31 100644 --- a/hw/pcnet.c +++ b/hw/pcnet.c @@ -1608,7 +1608,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val) static uint32_t pcnet_aprom_readb(void *opaque, uint32_t addr) { PCNetState *s = opaque; - uint32_t val = s->prom[addr &= 15]; + uint32_t val = s->prom[addr & 15]; #ifdef PCNET_DEBUG printf("pcnet_aprom_readb addr=0x%08x val=0x%02x\n", addr, val);