| Message ID | 1615784115-26559-1-git-send-email-tsimpson@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Hexagon (target/hexagon) fix typo in comment | expand |
Patchew URL: https://patchew.org/QEMU/1615784115-26559-1-git-send-email-tsimpson@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1615784115-26559-1-git-send-email-tsimpson@quicinc.com Subject: [PATCH] Hexagon (target/hexagon) fix typo in comment === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' ffe0b01 Hexagon (target/hexagon) fix typo in comment === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 8 lines checked Commit ffe0b013056f (Hexagon (target/hexagon) fix typo in comment) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1615784115-26559-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 3/15/21 5:55 AM, Taylor Simpson wrote: > Signed-of-by: Taylor Simpson <tsimpson@quicinc.com> 'git-commit -s' flag add the S-o-b line automatically ;) Otherwise: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/hexagon/op_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c > index 9f19007..7361a07 100644 > --- a/target/hexagon/op_helper.c > +++ b/target/hexagon/op_helper.c > @@ -297,7 +297,7 @@ int32_t HELPER(fcircadd)(int32_t RxV, int32_t offset, int32_t M, int32_t CS) > } > > /* > - * Hexagon FP operations return ~0 insteat of NaN > + * Hexagon FP operations return ~0 instead of NaN > * The hex_check_sfnan/hex_check_dfnan functions perform this check > */ > static float32 hex_check_sfnan(float32 x) >
On 3/14/21 10:55 PM, Taylor Simpson wrote: > Signed-of-by: Taylor Simpson<tsimpson@quicinc.com> > --- > target/hexagon/op_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Queued. r~
On 3/15/21 8:46 PM, Richard Henderson wrote: > On 3/14/21 10:55 PM, Taylor Simpson wrote: >> Signed-of-by: Taylor Simpson<tsimpson@quicinc.com> >> --- >> target/hexagon/op_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Queued. Can you s/Signed-of-by/Signed-off-by/ ? ;)
Le 15/03/2021 à 10:28, Philippe Mathieu-Daudé a écrit : > On 3/15/21 5:55 AM, Taylor Simpson wrote: >> Signed-of-by: Taylor Simpson <tsimpson@quicinc.com> > > 'git-commit -s' flag add the S-o-b line automatically ;) > > Otherwise: > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >> --- >> target/hexagon/op_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c >> index 9f19007..7361a07 100644 >> --- a/target/hexagon/op_helper.c >> +++ b/target/hexagon/op_helper.c >> @@ -297,7 +297,7 @@ int32_t HELPER(fcircadd)(int32_t RxV, int32_t offset, int32_t M, int32_t CS) >> } >> >> /* >> - * Hexagon FP operations return ~0 insteat of NaN >> + * Hexagon FP operations return ~0 instead of NaN >> * The hex_check_sfnan/hex_check_dfnan functions perform this check >> */ >> static float32 hex_check_sfnan(float32 x) >> > > Applied to my trivial-patches branch (with the fixed S-o-b) Thanks, Laurent
diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 9f19007..7361a07 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -297,7 +297,7 @@ int32_t HELPER(fcircadd)(int32_t RxV, int32_t offset, int32_t M, int32_t CS) } /* - * Hexagon FP operations return ~0 insteat of NaN + * Hexagon FP operations return ~0 instead of NaN * The hex_check_sfnan/hex_check_dfnan functions perform this check */ static float32 hex_check_sfnan(float32 x)