From patchwork Thu Nov 29 04:52:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Li Qiang X-Patchwork-Id: 1005057 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jtHPS4+X"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4354xs5s1Qz9s3Z for ; Thu, 29 Nov 2018 15:57:05 +1100 (AEDT) Received: from localhost ([::1]:52286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSENr-0007aW-DN for incoming@patchwork.ozlabs.org; Wed, 28 Nov 2018 23:57:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSEK9-0005HI-PJ for qemu-devel@nongnu.org; Wed, 28 Nov 2018 23:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSEK8-0007Pq-R6 for qemu-devel@nongnu.org; Wed, 28 Nov 2018 23:53:13 -0500 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:43395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSEK8-0007OQ-IC for qemu-devel@nongnu.org; Wed, 28 Nov 2018 23:53:12 -0500 Received: by mail-pg1-x542.google.com with SMTP id v28so347774pgk.10 for ; Wed, 28 Nov 2018 20:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=luZPC7/DqLcA2RZca3xoTMrfHx2Ra0jsPVrKhHeVmBs=; b=jtHPS4+Xm+qc0K2kzbSKYER/gC51fiLZ8G91DbVTPwEsar+IJfA5gOYES+zAzoiYTT aVohuda0Rn2b+avgycogCy1HLcvjzfvUVOObB2d2857Dswg9DrJvT1K2bQXcqSD7b2Ze KW6mIfdPXY3jJoXKrzSH1YHXN7jJ2vO2y/hyk1D3Xo0wTKGiK0eITd5fkHxL6EX96RBd JmiCHGxLTayHm7b7RZZ6myi2DsI+ogwrmGDp9LFDUWwp+fComfcxpfk3SkqBORj0KhuX EphFELIF54wZG7cEi1c/42BkqGVV2IiT58rsULUaQ/hD1B1KxWCFiW+p4+qrsbXKbvR1 sgvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=luZPC7/DqLcA2RZca3xoTMrfHx2Ra0jsPVrKhHeVmBs=; b=mBMce/Gm5xRVzhBSw+jFBbgPOjJQPovnioa0N8tCgdKpUoHhOiGjOQ9HfArQQQif53 OSh6yWgMaO2CGqmd2NWBZm+Varqo233MgGP/7FnBTbP9BP35BVHOQhwsE7EayXZg0UQz TOk2BxUQOdBQkd/JaeFisqFOOlXQKIgwQl/f0LMVd2cDX1TcLjX/eyl9dy8dNIBI/Rq/ IDCTvhrWPdfuOLd5891ixrIhONJX5ZdqlxsLrnF/CZnyZWAnVXqYQUwu2XcqfZeod1VW c7NCTdTxW0SUZluGkTmahJqlDlbwG6LFiUsQnIGO/jHAfVc7a/3T+FB4TZyuQ8mNYMhc nTdg== X-Gm-Message-State: AA+aEWZfB/vF3/UW6mAlDR6cjLR/FD8JS32u9ubZjBfKrtkopgcYIvUG Ax65tbppQHN4ukYDQn7l07APkmBp X-Google-Smtp-Source: AFSGD/XiRcc32mZBQgVaSNKZKbori9BotN4nE34BiY3xSJuvgylV/Wke1O6U78R466bMwq6Kw8hrIg== X-Received: by 2002:a62:7504:: with SMTP id q4mr44961pfc.180.1543467191615; Wed, 28 Nov 2018 20:53:11 -0800 (PST) Received: from localhost.localdomain.localdomain ([103.129.255.252]) by smtp.gmail.com with ESMTPSA id k26sm576747pgf.65.2018.11.28.20.53.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 20:53:11 -0800 (PST) From: Li Qiang To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com Date: Wed, 28 Nov 2018 20:52:11 -0800 Message-Id: <1543467132-2873-2-git-send-email-liq3ea@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1543467132-2873-1-git-send-email-liq3ea@gmail.com> References: <1543467132-2873-1-git-send-email-liq3ea@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH v3 1/2] hw: pc: use TYPE_XXX instead of constant strings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: darren.kenny@oracle.com, Li Qiang , armbru@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" TYPE_VMMOUSE is defined in vmmouse.c currently, move it to pc.h in order to use it in pc.c. Reviewed-by: Darren Kenny Reviewed-by: Markus Armbruster Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 6 +++--- hw/i386/vmmouse.c | 1 - include/hw/i386/pc.h | 3 +++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index f095725dba..73c7b777a0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1543,10 +1543,10 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, bool no_vmport) fdctrl_init_isa(isa_bus, fd); } - i8042 = isa_create_simple(isa_bus, "i8042"); + i8042 = isa_create_simple(isa_bus, TYPE_I8042); if (!no_vmport) { vmport_init(isa_bus); - vmmouse = isa_try_create(isa_bus, "vmmouse"); + vmmouse = isa_try_create(isa_bus, TYPE_VMMOUSE); } else { vmmouse = NULL; } @@ -1555,7 +1555,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, bool no_vmport) qdev_prop_set_ptr(dev, "ps2_mouse", i8042); qdev_init_nofail(dev); } - port92 = isa_create_simple(isa_bus, "port92"); + port92 = isa_create_simple(isa_bus, TYPE_PORT92); a20_line = qemu_allocate_irqs(handle_a20_line_change, first_cpu, 2); i8042_setup_a20_line(i8042, a20_line[0]); diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c index 5d2d278be4..4412eaf604 100644 --- a/hw/i386/vmmouse.c +++ b/hw/i386/vmmouse.c @@ -52,7 +52,6 @@ #define DPRINTF(fmt, ...) do { } while (0) #endif -#define TYPE_VMMOUSE "vmmouse" #define VMMOUSE(obj) OBJECT_CHECK(VMMouseState, (obj), TYPE_VMMOUSE) typedef struct VMMouseState diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 136fe497b6..c708ac9265 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -169,6 +169,9 @@ void gsi_handler(void *opaque, int n, int level); #define TYPE_VMPORT "vmport" typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address); +/* vmmouse.c */ +#define TYPE_VMMOUSE "vmmouse" + static inline void vmport_init(ISABus *bus) { isa_create_simple(bus, TYPE_VMPORT);