| Message ID | 1525376963-79623-7-git-send-email-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | include path cleanup | expand |
On Thu, May 03, 2018 at 10:50:28PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > trace/control.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > trace/control.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/trace/control.h b/trace/control.h > index 1903e22..eb65c8e 100644 > --- a/trace/control.h > +++ b/trace/control.h > @@ -267,6 +267,6 @@ char *trace_opt_parse(const char *optarg); > uint32_t trace_get_vcpu_event_count(void); > > > -#include "trace/control-internal.h" > +#include "control-internal.h" > > #endif /* TRACE__CONTROL_H */ >
diff --git a/trace/control.h b/trace/control.h index 1903e22..eb65c8e 100644 --- a/trace/control.h +++ b/trace/control.h @@ -267,6 +267,6 @@ char *trace_opt_parse(const char *optarg); uint32_t trace_get_vcpu_event_count(void); -#include "trace/control-internal.h" +#include "control-internal.h" #endif /* TRACE__CONTROL_H */
When pulling in headers that are in the same directory as C file (as opposed to one in include/), we should use its relative path, without a directory. Directory based path works more or less by accident. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- trace/control.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)