| Message ID | 1525376963-79623-4-git-send-email-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | include path cleanup | expand |
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/hppa/hppa_sys.h | 2 +- > hw/hppa/machine.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h > index a182d1f..f98cc8d 100644 > --- a/hw/hppa/hppa_sys.h > +++ b/hw/hppa/hppa_sys.h > @@ -10,7 +10,7 @@ > #include "hw/i386/pc.h" > #include "hw/irq.h" > > -#include "hw/hppa/hppa_hardware.h" > +#include "hppa_hardware.h" > > PCIBus *dino_init(MemoryRegion *, qemu_irq *, qemu_irq *); > > diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c > index 19033e2..70f509b 100644 > --- a/hw/hppa/machine.c > +++ b/hw/hppa/machine.c > @@ -16,7 +16,7 @@ > #include "hw/ide.h" > #include "hw/timer/i8254.h" > #include "hw/char/serial.h" > -#include "hw/hppa/hppa_sys.h" > +#include "hppa_sys.h" > #include "qemu/cutils.h" > #include "qapi/error.h" > #include "qemu/log.h" >
diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h index a182d1f..f98cc8d 100644 --- a/hw/hppa/hppa_sys.h +++ b/hw/hppa/hppa_sys.h @@ -10,7 +10,7 @@ #include "hw/i386/pc.h" #include "hw/irq.h" -#include "hw/hppa/hppa_hardware.h" +#include "hppa_hardware.h" PCIBus *dino_init(MemoryRegion *, qemu_irq *, qemu_irq *); diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 19033e2..70f509b 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -16,7 +16,7 @@ #include "hw/ide.h" #include "hw/timer/i8254.h" #include "hw/char/serial.h" -#include "hw/hppa/hppa_sys.h" +#include "hppa_sys.h" #include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/log.h"
When pulling in headers that are in the same directory as C file (as opposed to one in include/), we should use its relative path, without a directory. Directory based path works more or less by accident. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- hw/hppa/hppa_sys.h | 2 +- hw/hppa/machine.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)