From patchwork Tue Mar 27 21:31:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 891823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="ptbyRkRV"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 409ks34RL4z9s0y for ; Wed, 28 Mar 2018 08:38:15 +1100 (AEDT) Received: from localhost ([::1]:36228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0wIH-0007Nu-4t for incoming@patchwork.ozlabs.org; Tue, 27 Mar 2018 17:38:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0wBq-0002R3-Kd for qemu-devel@nongnu.org; Tue, 27 Mar 2018 17:31:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0wBn-00043J-FT for qemu-devel@nongnu.org; Tue, 27 Mar 2018 17:31:34 -0400 Received: from mail-bn3nam01on0060.outbound.protection.outlook.com ([104.47.33.60]:8096 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0wBn-00042U-38 for qemu-devel@nongnu.org; Tue, 27 Mar 2018 17:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZXMM6TI2hBIfyARPNE1BdsIgGbhQRYTNj2bsXSPPlZ0=; b=ptbyRkRVqUVrDH3UDwl6IsLRUnh4SKOWm+LueU8ATSXeSAZuA5XMxIYLP1s6ScwMgYPO7wp8do+Bpal7KroC3ZXn6nJWL8Vv/Ycaz+4EazaaherBcIlvmgRZE/zAdVM9mxTSAfjB0oJaEQgly4lgAmc7sk+EbggBTFRloxXv6UQ= Received: from linux-pyp0.amd.com (165.204.77.1) by DM5PR12MB1771.namprd12.prod.outlook.com (2603:10b6:3:113::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Tue, 27 Mar 2018 21:31:28 +0000 From: Babu Moger To: mst@redhat.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Tue, 27 Mar 2018 17:31:11 -0400 Message-Id: <1522186271-27743-10-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1522186271-27743-1-git-send-email-babu.moger@amd.com> References: <1522186271-27743-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR04CA0039.namprd04.prod.outlook.com (2603:10b6:903:c6::25) To DM5PR12MB1771.namprd12.prod.outlook.com (2603:10b6:3:113::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 192de3ca-588d-4b89-4643-08d5942a19d7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR12MB1771; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1771; 3:J0KxVWwSSs53iEeqOZAZRN8QA/AC9Mw2dPHqIzGZLuuppOpURXtzxzqHG+GFyPuO4bYF64w2zD7N1I3CywsVqSrA9dPYdhxydPHqnLqvzmpu57uoLOs2K3RH4t+Cc1T0fx373dYLnZ6Rl9OLqc/AM7BIDxB/1l8nG8+iIWSmnt+FY9SfUBMjYAVLhHAzE1GCR2MCsapLPPgkOounHY1sxDa3XBuAzZVKVmwac6yMFubbMIoWlCmzILoFO8Ebmy6D; 25:c4gqVLfr8vvF1kMRPrHbkTDIaGhXqSTrOvsSsk0+2tCrd1edHFR6rZMn8K5gdaRJJCwImY2agKO1EO0QTYmbryutPwlP+sfFqHFgHHMXPIohOfxSGD9rPQnTTjTd0BdTwDRLPMs4o0gB2CQ7D4TrqBezc5Nmv4yC72UDYdgBSTdqCkbk7U7uDgYrLD/59GmUEKzbaRCzaj2TPy1uuuzPvN74UZ5YrMA0oRQ6/POMq4IgIC3l7BDgwP3ULkfz8SgGml3Wu0CQJoF73TfDsF6NkJeCC7/s/KYMRB4ctW+cpJMz+RiSsiJF3pODv//qDGCngHUio6fkAiccFLBjP5CrnA==; 31:ENeAz839g+expYf505SYpry3ux+iYXlKv75hu0tKVnqR+wQ0IieMXMarGMtFZuxrfOmcujLKZ2tuoNcTsuqEd0LxelFpPh1yIvul6NBp82UnUwBsfnNkb05FPsCYq/pg/WzkQlP7stclD+XIixhj7D1HD0YusH1VIPRAckdjieq7GkqhMA+fU/7w7SdwDs2T5KAuR03IXrGwNdWcouk9tDLtMTUOlfNxU/x6KMjFuZs= X-MS-TrafficTypeDiagnostic: DM5PR12MB1771: X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1771; 20:6ZQTK6fDmLHPrC6tyjMvFiIg4YO4IuXafm/uk686KbfUfzuqLFno/dSFdp4FmNVz0e/JOoFy9vxdjEifObjtH9p1fE1Q3jyNux2azQOg1UoXJUpXPE4wl0mn8PDt/dxzmz2eaPbzaFDD1v3b/+B+pIRrAfZMXiJxjSpVPAS4piUxp0bN6jNl0RdZrbudu0k1fo/F6+aU6pOStWmoMTxCVtBBV4/KQOIxUXDIPm+3Zj3CG3+nYpThcKXdjNqqPmVmea7R70bK9M7lMYu5fn184cGakkK9L+t9YHmeAabR65bjMyhoQ8Q1E4492Aa+IviEtfsoBzOxL2hc9PYLBwg5wOVA31rgtFdY8XUW8Lv2wGv448Rtg4l4d4mTgPq/RoTGBI2TcZQPJgKmbm2AvsuBJS9aEKl/HoR5cpnyOmh5deITx94uKc23yZSApiVznHI+LTt9qE9YwoKEYgO7QbZsNyZcmsxbs28b/rJDpNkqoguvuBz/7nZMPuxGQEf16814; 4:JpiYLfkmqjchOxnZYfwcPEjiZaBrvHq/ld4qMo1Hq9Ty/Gfm1nzBXZWW97IgHh9KpKo0jDnsGFwRWLWyUb6k82U5dyacz1S2WgZ1pauRCOzNXNndDzsJs1fhMoZ8eMkGzwzGVUmi5oe/y3EjRO2JH7J8rWod8CFBtMqQm6H38/2O64vedlyZ6OFIY01Lp2c/kbqdNwIv7dFRpzRHyBP/yKqXNA6lugdkH6RXMJqSD8rqzG7a0XIKFZUGoNykqtGLIJ7dlYo+oOBJ5x6ZtPKSAzNQAmEpTFPAGsboNxm/LcKslhgZjnrOZB+zfS76yyL8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR12MB1771; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1771; X-Forefront-PRVS: 0624A2429E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(39380400002)(376002)(39860400002)(199004)(189003)(36756003)(6666003)(105586002)(47776003)(76176011)(25786009)(66066001)(53416004)(97736004)(7696005)(51416003)(386003)(486005)(59450400001)(486005)(2906002)(72206003)(4720700003)(6486002)(52116002)(4326008)(11346002)(5660300001)(7736002)(305945005)(53936002)(81156014)(50466002)(8676002)(6346003)(81166006)(16526019)(106356001)(68736007)(50226002)(8936002)(3846002)(476003)(478600001)(26005)(2616005)(186003)(446003)(316002)(6116002)(956004)(86362001)(16586007)(48376002)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1771; H:linux-pyp0.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR12MB1771; 23:GevVnb6QwKLwC7pxkUUsUkWcMkmdiJmiDxuBIjh2U?= KDABPAPDBrN2py9Fp5TNyPfFRKLPaO0VdrJuFDLzC7S3wTFs2hunEjSD8soSzs6sz4IgKLOXcY+/CjcayRPe0Tjfrgpav0Vm4CnvljOtc4ucyIVjAQ+0XvhRbN5G6L1hDZT3tnl3Bk9zwplZsyoPP6MC8CvGOlGW+gZHt5hco6yM1sKet7le+H6kbRlqCjq1CE/KLgPp309ArjiQZuLrpJQlXF+2Q9y1Q+80HyW2XOH7qMD6Oo8vOCVdSVQPnlfxF/rV+LUS8H0AbYhOoAsyh4jDxuT1v+KJBAjHGR+6iBzIk1INmPfEXkn63EW27DRCXATENLyQFznuIjDvLBaxaOyeLRLTYBWzKe8r/SnUekuvHH+Ixk/sYH2b76itEjeO6sT7fzuu01sse/4S4Z69LOKtUiRdIvUTDSEiHKYwk0q54KqTmbGkDPc5pb51sP7ZObmCuNZo+cJUb7N/MqBh2Khl0bbit6x1rMzn87g7OcqmRfCzAPpGhERX0WB0jcBagz1dHxeY+ZhYJXBcRwmSbcXko6rR7RPOFCtyCBi40H1Caz69D44a6JPmN5GOiUKtVnDcJW9VDQo+KQlGP75yS1WNDZrDGf9L+exXtqoRdp6ILD8MNsk11UGl3LFjrpWHXdTdDGnAuv1+Jvxw2bJC06wQEX92IjpXgmI7Fo9q6fiPQJmfwR8XAuuJ1oissg6mPYcMvpIe/h0NJdIUYIwlKC7j+QOnDaE9ZAKoI2qRbwmZ95ZqV++zqGyZdbsl4+wwFzVf4fjRjUk8tKN8a0AFUHK0e+naxbMPM0HTSNVo/b/xETFtBm3VNdG60uT/mo/uudVe63dRYHjIJoWamDMWXdQXoHYHZ9CKAOKLyvumFwPJdmj16cxyNAZ3WHSob7bk8AQTgpOY2c5WQNtqs2MLOsT/IeQypmJM+sPgyv4RiXor1FE79KpHLL6S2LzzeBpmc+wE8MFrvQfJoYbFIXHDQCeCph092Qt8a7pbZYOL8PMqctmd+Zn2b462/VemJpV81IIBZABz0HSf5K7nBWKkKyUS4cUDbus3kKCtP87wYXMZ69mXBUXx2iqbi/VHLL4i7B+ubDoCiccbzAi6ho/6woC74LFXsa8MA/0cqZNIuTSfvJQxYzu44kWEOosOS3l44zAAF1xvOAGdh9tKfOOj/2n3j9SdkAleKR4fvh+1YQYdcBxUqJTN10sqjZSBOn1gPtaQPD0kAHBCxRX3EuptJdZTP/Hxibq6dqfRBXJMMofWA== X-Microsoft-Antispam-Message-Info: VzNQxIppl7He0KH4QJvjcDLPH6XyOjnPvQEcSeQS/nb8PpoZklnFMF/F0fGpEnamWJjIwuIMdlkhhYlZzZVIvb6MgdQsdiKF/cFE+R4lC4ihx+6ovezN8bBDratRrpKZSnEPIakkVBsDW8TcF2iouVOQsTcozOab6vEXSWNBsQOkFwDErYtP5inUo0mNOGBb X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1771; 6:X65Of++H8Xmozpx2V4b/+LDiZgzJBb9GO2wwmqiXdgr+dqf7xAM6TVUpRZzKEQFL3p1hIQXCxmmtrsgEdDA0VR5OVMOI7gyoFfrojawAzasktbsaSceHE0BbxLqU3yTjTmoLuz/3JLzOqvGbEJ++7w0j0cXME82fks7i8GFzvPuFIxfVPoev6RE6Xdp74Vzq/7xax3op1XtHuFDBQjClC9iDwxswkpRcZpVn2kgGvOGwW5fFjO2Hc9WD2PxpfAfrm2BsSQwqxIYVIhQTvbM5D2B/z86JmAG2uEbzpYxeKzacxAdkMN3ZfCsuw3Ouu9K9/dgooB8wT6im7M2vTmsswaMapuvbb3rZYdVXaIN8AKQsGC/dkYq9dQqTZbJ/aH3vkZ7p6KOs6yP2vDJK91I9d5VxCuhgC3+vt190G1EmSCXdFDrWTzy7ojHYLt+CYFf2cLKoDJWcJNWZ0EIbj3mPiA==; 5:He27bgr6hsjDhJLkfJMGbcc3XRg2oh+kZf7C62xJIU6Xw15MOsaAxYDIop/1UvHZP0jYHjO/Qa/rl6X7aXBYMLcVgFGKpHaFPbopwrySCU1Ngd6ryRFSoZpwYVafJYmElDoJ/1SiO67WTSQgnY3GMaRbj6QjGI9SQfpXIcv3ZdY=; 24:FDcUm8Q9YZ+FuvOpeDOQ8cc4E9+WCgWjUryUJ5xXB1YuImeFAJaHo7SR3KlGPrkW9J+fAW9mi1Co6Vijt0hlVI4BrTSCAxVvE9NEVTAHusI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1771; 7:ACd8UZfWwhp2i1tV7+tSbn5coa+H0vL6Y9rRnFh/EwchjNqKYSTAEb/jlM9daclvzo/wU/RwUOnNyMxR7rUaj1HdB8NBmdrh979O9zBydpwUM2Iy3iowvZS0c7htQOVSU0JSXGKQ8z42LYUJ+0yM8fJJMrrOBBkgNgWGFUApOpnLp8p8IDFw+CsiiIW7qQi4tUlqMfdzJASG4WFoA6D06mulDft8khpWAB0SBC0T6300xp/7dhd/bUdmySBOyB6T; 20:eDSgiLSUteIOCY0NzRmnTKOxsfExbB8+q6Lhn3TmzNX0bESzbp00XizbeIAclPmD3a7caScz5TjKH19a7OM7HwU4I71R/tbXxHSVZCzSW4lrMgnjxg4UX+scE+gidfhHDkUGm9HRL+TnIFD3R4lzmcRa7voeFLoluVprL86YQkxEbf9SvPDDSxqnN3p0DcsBJBztmgtWLbtikEOHeIkGQadzMmyGm6Ryr+A6ICoxQXSBYr2SSfIQeED1JgvNKZPR X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2018 21:31:28.0087 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 192de3ca-588d-4b89-4643-08d5942a19d7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1771 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.60 Subject: [Qemu-devel] [PATCH v5 9/9] i386: Remove generic SMT thread check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger --- target/i386/cpu.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index f8e7325..e216d54 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4824,17 +4824,20 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) qemu_init_vcpu(cs); - /* Only Intel CPUs support hyperthreading. Even though QEMU fixes this - * issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX - * based on inputs (sockets,cores,threads), it is still better to gives + /* Most Intel and certain AMD CPUs support hyperthreading. Even though QEMU + * fixes this issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX + * based on inputs (sockets,cores,threads), it is still better to give * users a warning. * * NOTE: the following code has to follow qemu_init_vcpu(). Otherwise * cs->nr_threads hasn't be populated yet and the checking is incorrect. */ - if (!IS_INTEL_CPU(env) && cs->nr_threads > 1 && !ht_warned) { - error_report("AMD CPU doesn't support hyperthreading. Please configure" - " -smp options properly."); + if (IS_AMD_CPU(env) && + !(env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) && + cs->nr_threads > 1 && !ht_warned) { + error_report("This family of AMD CPU doesn't support " + "hyperthreading. Please configure -smp " + "options properly."); ht_warned = true; }