diff mbox

[RFC] LZ4 compression option for SPICE

Message ID 1508539.cfTQauU1Ry@javinlg
State New
Headers show

Commit Message

Javier Celaya Jan. 8, 2015, 10:50 a.m. UTC 
Hello

Recently, SPICE included the lz4 compression algorithm. This patch adds
a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not 
exist before the commit that added this compression algorithm, so it should be 
guarded with conditional compilation. How do you think this should be done? 
Wait for the next stable version of spice-server and check for 
SPICE_SERVER_VERSION? Or add a specific flag?

Thank you
---
 ui/spice-core.c | 1 +
 1 file changed, 1 insertion(+)

--
1.9.3

Comments

Christophe Fergeau Jan. 20, 2015, 4:08 p.m. UTC | #1 
Hey,

On Thu, Jan 08, 2015 at 11:50:13AM +0100, Javier Celaya wrote:
> Hello
> 
> Recently, SPICE included the lz4 compression algorithm. This patch adds
> a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not 
> exist before the commit that added this compression algorithm, so it should be 
> guarded with conditional compilation. How do you think this should be done? 
> Wait for the next stable version of spice-server and check for 
> SPICE_SERVER_VERSION? Or add a specific flag?

Version check seems good, we probably can raise spice-server version in
git preemptively so that you can have a working version check now.

Given that lz4 support is optional, spice_server_set_image_compression
should probably error out if we try to set lz4 but it's not supported.

Christophe
diff mbox

Patch

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 6467fa4..fb6534e 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -359,6 +359,7 @@  static const char *compression_names[] = {
     [ SPICE_IMAGE_COMPRESS_QUIC ]     = "quic",
     [ SPICE_IMAGE_COMPRESS_GLZ ]      = "glz",
     [ SPICE_IMAGE_COMPRESS_LZ ]       = "lz",
+    [ SPICE_IMAGE_COMPRESS_LZ4 ]      = "lz4",
 };
 #define parse_compression(_name)                                        \
     parse_name(_name, "image compression",                              \