From patchwork Tue Apr 11 12:05:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 858585 jemmy X-Patchwork-Id: 749431 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w2QkS6fn8z9sNS for ; Tue, 11 Apr 2017 22:06:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UjNQ2w47"; dkim-atps=neutral Received: from localhost ([::1]:38943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxuYg-0005Le-DX for incoming@patchwork.ozlabs.org; Tue, 11 Apr 2017 08:06:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxuYA-0005KC-PU for qemu-devel@nongnu.org; Tue, 11 Apr 2017 08:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxuY5-0001KV-UB for qemu-devel@nongnu.org; Tue, 11 Apr 2017 08:05:34 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:33394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxuY5-0001K6-N3; Tue, 11 Apr 2017 08:05:29 -0400 Received: by mail-pf0-x243.google.com with SMTP id c198so10258381pfc.0; Tue, 11 Apr 2017 05:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=BgMo53qzMcSQIPdh8evn2E0CPLLCleUWcGF7LfKUugY=; b=UjNQ2w47h327NAjr75b6PgJZse+CJxfOOV6nwCRf+A7Op/BvwJk6gEWc01qZnoa6+8 YlAInaTb79rrGdz+l4/jCbVD7Y1yNha4XNOGH45eNMp8ZnPn0yI6D7+Cy1OXagi8cAXI 4hu7mzWAA7855IWZL5SwS/p7P6GxfpXh6/CIGtih4VYT2LVuwJs4UnZu/43Lxd/rtzvg bRM5xJCiUgo/M9cGWf0i+U3yA8fATMpiXOrOx4ZowrToIZFYkBMWAAP4gZkL+j8PWfjd pbP9g3lEGi1/LX6dq4dPKhQVQRZJ4RYR1jthPIJY8rCS0TTTfDuObLWqApC3AtG/wvkR bFxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BgMo53qzMcSQIPdh8evn2E0CPLLCleUWcGF7LfKUugY=; b=IRDAI4HpRAlHZP345sPimBfmReI3NXMKSH5hrojFciiVGxVksf0CaZZcCdXB+VgoIh sGwse+vI1xvRBIoJay4e2jJ1F1q+Dg7vAJ8WLKltZs0cFeZJXi391KVV/04OZWajDVd4 rz/NCJRYj89tWBQPoDp1tZbLGYbXsh87IlAfEAF4ysu0VgF/fITEzoD4fVFSUmsSO4Oj ttyVC3qGrFHQfngHTNROTKtyuTp97QG1BgRPtNXNUSHbWK/ioJGBYIyxJRSvG/eyfcxf bjAXD6w6+KTnti5GojKzaQtZIpb8i6t3K1F8YE06cq335kxwuwS728cGmgLQzenIvAPP jz5g== X-Gm-Message-State: AFeK/H2coF1vkpoVcmT5rcSC+iSHTkTKNkxz0Nc0Y7CafrZOhul7+mtTDvRV/359a4ka4A== X-Received: by 10.98.46.134 with SMTP id u128mr60379696pfu.264.1491912328829; Tue, 11 Apr 2017 05:05:28 -0700 (PDT) Received: from localhost.localdomain ([119.28.70.25]) by smtp.gmail.com with ESMTPSA id i15sm30399264pfj.51.2017.04.11.05.05.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 05:05:28 -0700 (PDT) From: jemmy858585@gmail.com X-Google-Original-From: lidongchen@tencent.com To: qemu-devel@nongnu.org Date: Tue, 11 Apr 2017 20:05:12 +0800 Message-Id: <1491912312-23393-1-git-send-email-lidongchen@tencent.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH v4] migration/block: use blk_pwrite_zeroes for each zero cluster X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com, Lidong Chen Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Lidong Chen BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, this maybe cause the qcow2 file size is bigger after migration. This patch check each cluster, use blk_pwrite_zeroes for each zero cluster. Signed-off-by: Lidong Chen Reviewed-by: Stefan Hajnoczi --- migration/block.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 7734ff7..5d0635a 100644 --- a/migration/block.c +++ b/migration/block.c @@ -885,6 +885,8 @@ static int block_load(QEMUFile *f, void *opaque, int version_id) int64_t total_sectors = 0; int nr_sectors; int ret; + BlockDriverInfo bdi; + int cluster_size; do { addr = qemu_get_be64(f); @@ -919,6 +921,15 @@ static int block_load(QEMUFile *f, void *opaque, int version_id) error_report_err(local_err); return -EINVAL; } + + ret = bdrv_get_info(blk_bs(blk), &bdi); + if (ret == 0 && bdi.cluster_size > 0 && + bdi.cluster_size <= BLOCK_SIZE && + BLOCK_SIZE % bdi.cluster_size == 0) { + cluster_size = bdi.cluster_size; + } else { + cluster_size = BLOCK_SIZE; + } } if (total_sectors - addr < BDRV_SECTORS_PER_DIRTY_CHUNK) { @@ -932,10 +943,28 @@ static int block_load(QEMUFile *f, void *opaque, int version_id) nr_sectors * BDRV_SECTOR_SIZE, BDRV_REQ_MAY_UNMAP); } else { + int i; + int64_t cur_addr; + uint8_t *cur_buf; + buf = g_malloc(BLOCK_SIZE); qemu_get_buffer(f, buf, BLOCK_SIZE); - ret = blk_pwrite(blk, addr * BDRV_SECTOR_SIZE, buf, - nr_sectors * BDRV_SECTOR_SIZE, 0); + for (i = 0; i < BLOCK_SIZE / cluster_size; i++) { + cur_addr = addr * BDRV_SECTOR_SIZE + i * cluster_size; + cur_buf = buf + i * cluster_size; + + if (buffer_is_zero(cur_buf, cluster_size)) { + ret = blk_pwrite_zeroes(blk, cur_addr, + cluster_size, + BDRV_REQ_MAY_UNMAP); + } else { + ret = blk_pwrite(blk, cur_addr, cur_buf, + cluster_size, 0); + } + if (ret < 0) { + break; + } + } g_free(buf); }