From patchwork Fri Mar 31 11:27:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kurz X-Patchwork-Id: 745597 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vvfPw6YhTz9s03 for ; Fri, 31 Mar 2017 22:28:20 +1100 (AEDT) Received: from localhost ([::1]:40144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctuj4-0002pi-Dm for incoming@patchwork.ozlabs.org; Fri, 31 Mar 2017 07:28:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctuiX-0002oJ-EA for qemu-devel@nongnu.org; Fri, 31 Mar 2017 07:27:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctuiS-0007KN-Hs for qemu-devel@nongnu.org; Fri, 31 Mar 2017 07:27:45 -0400 Received: from 7.mo179.mail-out.ovh.net ([46.105.61.94]:55726) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctuiS-0007JS-Bl for qemu-devel@nongnu.org; Fri, 31 Mar 2017 07:27:40 -0400 Received: from player755.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 266873420C for ; Fri, 31 Mar 2017 13:27:39 +0200 (CEST) Received: from bahia.lan (huguette.tetaneutral.net [91.224.149.27]) (Authenticated sender: groug@kaod.org) by player755.ha.ovh.net (Postfix) with ESMTPA id 54FF42600AF; Fri, 31 Mar 2017 13:27:33 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 13:27:31 +0200 Message-ID: <149095965106.26233.18168802196576430962.stgit@bahia.lan> In-Reply-To: <149095959109.26233.3201018420228514740.stgit@bahia> References: <149095959109.26233.3201018420228514740.stgit@bahia> User-Agent: StGit/0.17.1-20-gc0b1b-dirty MIME-Version: 1.0 X-Ovh-Tracer-Id: 4407616661432801651 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelhedrledugdeflecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.61.94 Subject: [Qemu-devel] [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Greg Kurz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" We don't need to wait for the PDU active list to be empty: virtfs_reset() already takes care of that. Signed-off-by: Greg Kurz Reviewed-by: Li Qiang --- hw/9pfs/9p.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 86ed9065c4e2..16ef6bd5bd8c 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -3601,6 +3601,7 @@ static void coroutine_fn virtfs_co_reset(void *opaque) VirtfsCoResetData *data = opaque; virtfs_reset(&data->pdu); + assert(QLIST_EMPTY(&data->pdu.s->active_list)); data->done = true; } @@ -3609,10 +3610,6 @@ void v9fs_reset(V9fsState *s) VirtfsCoResetData data = { .pdu = { .s = s }, .done = false }; Coroutine *co; - while (!QLIST_EMPTY(&s->active_list)) { - aio_poll(qemu_get_aio_context(), true); - } - co = qemu_coroutine_create(virtfs_co_reset, &data); qemu_coroutine_enter(co);