From patchwork Thu Jun 23 05:48:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 639513 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rZrk42hkJz9t0X for ; Thu, 23 Jun 2016 16:13:16 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b=mafTjYdy; dkim-atps=neutral Received: from localhost ([::1]:34550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFxt4-00034u-9f for incoming@patchwork.ozlabs.org; Thu, 23 Jun 2016 02:13:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFxTw-00079R-2x for qemu-devel@nongnu.org; Thu, 23 Jun 2016 01:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFxTq-0002av-VV for qemu-devel@nongnu.org; Thu, 23 Jun 2016 01:47:15 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:55471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFxTq-0002ZM-Hr; Thu, 23 Jun 2016 01:47:10 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3rZr7q2v1Bz9t1j; Thu, 23 Jun 2016 15:47:02 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1466660823; bh=itqjEObQdBDf4pKMCFl8P/ham05pNmhBVlYyk7yJDM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mafTjYdyfE5rMV7Ihr/tV+WzsfChb5I9zss3GdPlI7yXUsQiVUVqVgaGo8fz+LcXb Dca7FA3616F3+4GysAlokpFBOQSv9uOzrNNmM3F2MwxWb0X+kPb/DSA5VpYI2kftXu xXE0WTyhwfLjqDlHnDMh1QTEq9FLUiETfXLQEjzY= From: David Gibson To: peter.maydell@linaro.org Date: Thu, 23 Jun 2016 15:48:44 +1000 Message-Id: <1466660926-1544-16-git-send-email-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1466660926-1544-1-git-send-email-david@gibson.dropbear.id.au> References: <1466660926-1544-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 15/17] ppc: Move exception generation code out of line X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Benjamin Herrenschmidt There's no point inlining this, if you hit the exception case you exit anyway, and not inlining saves about 100K of code size (and cache footprint). Signed-off-by: Benjamin Herrenschmidt [clg: removed '__attribute__((noinline))' from original patch ] Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- target-ppc/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 55102bf..fcead98 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -284,7 +284,7 @@ void gen_update_current_nip(void *opaque) tcg_gen_movi_tl(cpu_nip, ctx->nip); } -static inline void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t error) +static void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t error) { TCGv_i32 t0, t1; if (ctx->exception == POWERPC_EXCP_NONE) { @@ -298,7 +298,7 @@ static inline void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t ctx->exception = (excp); } -static inline void gen_exception(DisasContext *ctx, uint32_t excp) +static void gen_exception(DisasContext *ctx, uint32_t excp) { TCGv_i32 t0; if (ctx->exception == POWERPC_EXCP_NONE) { @@ -310,7 +310,7 @@ static inline void gen_exception(DisasContext *ctx, uint32_t excp) ctx->exception = (excp); } -static inline void gen_debug_exception(DisasContext *ctx) +static void gen_debug_exception(DisasContext *ctx) { TCGv_i32 t0;