From patchwork Fri Jun 17 06:36:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 636798 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rW9Wy68PDz9t1r for ; Fri, 17 Jun 2016 16:36:46 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b=UbNg1UCN; dkim-atps=neutral Received: from localhost ([::1]:54201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDnOW-0006nL-OU for incoming@patchwork.ozlabs.org; Fri, 17 Jun 2016 02:36:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDnN0-0005Y5-Ad for qemu-devel@nongnu.org; Fri, 17 Jun 2016 02:35:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDnMv-00089b-8W for qemu-devel@nongnu.org; Fri, 17 Jun 2016 02:35:09 -0400 Received: from ozlabs.org ([103.22.144.67]:39029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDnMu-00088j-TY; Fri, 17 Jun 2016 02:35:05 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3rW9Tt0K9Rz9t21; Fri, 17 Jun 2016 16:34:57 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1466145298; bh=3pqxidhquB7FM4YwxpuTlSKf1/WlStxB3lYFjLSaYJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UbNg1UCNI3h7jR9Puiy9Yy9A9wBUOZTNCSGG8c/3km1OcUXB/AOKxMP0RfxtS6kNS OMZSoQ46sm3P9NOgAHnHDC3iumclRma/id64W52lfVDqdE7CE6XQaSCy7t62EU+N7j McFuTZvM+RCV27TUloLiF63cD0gI9qIMJlRtDHY0= From: David Gibson To: peter.maydell@linaro.org Date: Fri, 17 Jun 2016 16:36:25 +1000 Message-Id: <1466145399-32209-5-git-send-email-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1466145399-32209-1-git-send-email-david@gibson.dropbear.id.au> References: <1466145399-32209-1-git-send-email-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 04/18] vfio: Fix broken EEH X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, imammedo@redhat.com, Gavin Shan , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Gavin Shan vfio_eeh_container_op() is the backend that communicates with host kernel to support EEH functionality in QEMU. However, the functon should return the value from host kernel instead of 0 unconditionally. dwg: Specifically the problem occurs for the handful of EEH sub-operations which can return a non-zero, non-error result. Signed-off-by: Gavin Shan Acked-by: Alex Williamson [dwg: clarification to commit message] Signed-off-by: David Gibson --- hw/vfio/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 5ff5e92..1898f1f 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -1257,7 +1257,7 @@ static int vfio_eeh_container_op(VFIOContainer *container, uint32_t op) return -errno; } - return 0; + return ret; } static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)