From patchwork Fri Mar 18 10:26:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 599415 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qRM9306L7z9s5Q for ; Fri, 18 Mar 2016 21:36:55 +1100 (AEDT) Received: from localhost ([::1]:42796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agrm1-0005GF-8D for incoming@patchwork.ozlabs.org; Fri, 18 Mar 2016 06:36:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agrlg-0004uP-RG for qemu-devel@nongnu.org; Fri, 18 Mar 2016 06:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agrld-0001KP-LB for qemu-devel@nongnu.org; Fri, 18 Mar 2016 06:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agrld-0001KL-G8 for qemu-devel@nongnu.org; Fri, 18 Mar 2016 06:36:29 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 888D0C00B8C3 for ; Fri, 18 Mar 2016 10:26:41 +0000 (UTC) Received: from nilsson.home.kraxel.org (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2IAQerC022943; Fri, 18 Mar 2016 06:26:41 -0400 Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id F3EAC81728; Fri, 18 Mar 2016 11:26:36 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Fri, 18 Mar 2016 11:26:35 +0100 Message-Id: <1458296795-29995-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1458296795-29995-1-git-send-email-kraxel@redhat.com> References: <1458296795-29995-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Gerd Hoffmann , Christophe Fergeau Subject: [Qemu-devel] [PULL 5/5] spice: Disallow use of gl + TCP port X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Christophe Fergeau Currently, virgl support has to go through a local unix socket, trying to connect to a VM using -spice gl through spice://localhost:5900 will only result in a black screen. This commit errors out when the user tries to start a VM with both GL support and a port/tls-port set. This would fit better in spice-server, but currently QEMU does not call into spice-server when parsing 'gl' on its command line, so we have to do this check in QEMU instead. Signed-off-by: Christophe Fergeau Reviewed-by: Marc-André Lureau Message-id: 1457955672-28758-1-git-send-email-cfergeau@redhat.com [ applied codestyle fix: break long line ] Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ui/spice-core.c b/ui/spice-core.c index e117925..61db3c1 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -828,6 +828,11 @@ void qemu_spice_init(void) #ifdef HAVE_SPICE_GL if (qemu_opt_get_bool(opts, "gl", 0)) { + if ((port != 0) || (tls_port != 0)) { + error_report("SPICE GL support is local-only for now and " + "incompatible with -spice port/tls-port"); + exit(1); + } if (egl_rendernode_init() == 0) { display_opengl = 1; }