From patchwork Mon Jan 18 15:16:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 569568 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1038C140324 for ; Tue, 19 Jan 2016 02:21:52 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=AGlxjRpo; dkim-atps=neutral Received: from localhost ([::1]:60306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBcr-0007eH-R1 for incoming@patchwork.ozlabs.org; Mon, 18 Jan 2016 10:21:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBYP-0008Pn-2w for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:17:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLBYL-0001hV-5F for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:17:12 -0500 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:34085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBYK-0001hC-Uv for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:17:09 -0500 Received: by mail-wm0-x22b.google.com with SMTP id u188so108059475wmu.1 for ; Mon, 18 Jan 2016 07:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w9i4gntVlpd3EjrhcBJCq1U5vmvCvufW/z/D1o6yY/g=; b=AGlxjRpoH9F4HBpIx+AuqSnVg3+4G1NsQWSx7eh6egTwfJfh9OXB//xwwV2b8aCgN/ ZrgX1/7Lg2t1l9ilVFjX4FNStGD85yoo/NV0e7KFBeqUvMG7XDURSh7DLuTlRZB5TQ/5 /byImCTP5kZQyVIMkBmCfFHDzSV87aZWZbG/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w9i4gntVlpd3EjrhcBJCq1U5vmvCvufW/z/D1o6yY/g=; b=lt43KvHtAX0nHLmL2I7GauJjOhx9nqfP+jEFeIAxXslHLinjYpX2EVR4BVJSe9Bx/u /Jw2fahtwVySYWwk+lAaK+2CGfbJN8kh5gQkV31XdE8Xq9Ulr+fDqq/F61nZPCaUhtq6 7mihdsUIja80HcwtrT65ZzBTzUiB1QkhTRcLZxSnU6nvG4E0q+dvIImhC3qQAZSklieP lEt+8x1pgjYXfrNQLIQEjvlqG+ph/w1hssdpgCJjOm+ckQvixvAFMXBozGua9QQF7Tex dCcih7ngSAN6qn41BHbyG2bgR1c5rIOPGUU+2q+Qs6OXKbjIB9UBcFR8+NhjZ94n/7Hr oXxQ== X-Gm-Message-State: AG10YORuaSn+cgIhGK1J9ZnX80O28c85B0vi6l5ZTj4GGcIjMYXVQErA3oB+dIyTLaFjFxLu X-Received: by 10.28.186.87 with SMTP id k84mr13546237wmf.13.1453130228426; Mon, 18 Jan 2016 07:17:08 -0800 (PST) Received: from new-host-9.home (LMontsouris-657-1-37-90.w80-11.abo.wanadoo.fr. [80.11.198.90]) by smtp.gmail.com with ESMTPSA id o7sm24230067wjf.45.2016.01.18.07.17.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jan 2016 07:17:06 -0800 (PST) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, david@gibson.dropbear.id.au, alex.williamson@redhat.com Date: Mon, 18 Jan 2016 15:16:44 +0000 Message-Id: <1453130204-655-9-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1453130204-655-1-git-send-email-eric.auger@linaro.org> References: <1453130204-655-1-git-send-email-eric.auger@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22b Cc: thomas.lendacky@amd.com, thuth@redhat.com, b.reynal@virtualopensystems.com, patches@linaro.org, crosthwaitepeter@gmail.com, suravee.suthikulpanit@amd.com, pbonzini@redhat.com, alex.bennee@linaro.org, christoffer.dall@linaro.org Subject: [Qemu-devel] [PATCH v5 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qemu_fdt_setprop self-asserts in case of error hence no need to check the returned value. Signed-off-by: Eric Auger --- v3 -> v4: fix returned value --- hw/arm/sysbus-fdt.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c index bf6ec24..d179214 100644 --- a/hw/arm/sysbus-fdt.c +++ b/hw/arm/sysbus-fdt.c @@ -216,7 +216,7 @@ static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) PlatformBusDevice *pbus = data->pbus; void *fdt = data->fdt; const char *parent_node = data->pbus_node_name; - int compat_str_len, i, ret = -1; + int compat_str_len, i; char *nodename; uint32_t *irq_attr, *reg_attr; uint64_t mmio_base, irq_number; @@ -241,12 +241,8 @@ static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) reg_attr[2 * i + 1] = cpu_to_be32( memory_region_size(&vdev->regions[i]->mem)); } - ret = qemu_fdt_setprop(fdt, nodename, "reg", reg_attr, - vbasedev->num_regions * 2 * sizeof(uint32_t)); - if (ret) { - error_report("could not set reg property of node %s", nodename); - goto fail_reg; - } + qemu_fdt_setprop(fdt, nodename, "reg", reg_attr, + vbasedev->num_regions * 2 * sizeof(uint32_t)); irq_attr = g_new(uint32_t, vbasedev->num_irqs * 3); for (i = 0; i < vbasedev->num_irqs; i++) { @@ -256,17 +252,12 @@ static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) irq_attr[3 * i + 1] = cpu_to_be32(irq_number); irq_attr[3 * i + 2] = cpu_to_be32(GIC_FDT_IRQ_FLAGS_LEVEL_HI); } - ret = qemu_fdt_setprop(fdt, nodename, "interrupts", + qemu_fdt_setprop(fdt, nodename, "interrupts", irq_attr, vbasedev->num_irqs * 3 * sizeof(uint32_t)); - if (ret) { - error_report("could not set interrupts property of node %s", - nodename); - } g_free(irq_attr); -fail_reg: g_free(reg_attr); g_free(nodename); - return ret; + return 0; }