From patchwork Wed Nov 18 18:53:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 546168 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 92F55141478 for ; Thu, 19 Nov 2015 05:58:31 +1100 (AEDT) Received: from localhost ([::1]:37762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7w5-0005PH-NR for incoming@patchwork.ozlabs.org; Wed, 18 Nov 2015 13:58:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7vm-0004u6-1B for qemu-devel@nongnu.org; Wed, 18 Nov 2015 13:58:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz7vl-0003wi-8C for qemu-devel@nongnu.org; Wed, 18 Nov 2015 13:58:09 -0500 Received: from bombadil.infradead.org ([2001:1868:205::9]:38111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7vj-0003oT-Ga; Wed, 18 Nov 2015 13:58:07 -0500 Received: from p4ff2f312.dip0.t-ipconnect.de ([79.242.243.18] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zz7vN-0007Mn-QJ; Wed, 18 Nov 2015 18:57:46 +0000 From: Christoph Hellwig To: Keith Busch Date: Wed, 18 Nov 2015 19:53:12 +0100 Message-Id: <1447872792-8508-3-git-send-email-hch@lst.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447872792-8508-1-git-send-email-hch@lst.de> References: <1447872792-8508-1-git-send-email-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:1868:205::9 Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Subject: [Qemu-devel] [PATCH 2/2] nvme: bump PCI revision X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The broken Identify implementation in earlier Qemu versions means we need to blacklist it from issueing the NVMe 1.1 Identify Namespace List command. As we want to be able to use it in newer Qemu versions we need a way to identify those. Bump the PCI revision as a guest visible indicator of this bug fix. Signed-off-by: Christoph Hellwig --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 4a6443f..360be71 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -946,7 +946,7 @@ static void nvme_class_init(ObjectClass *oc, void *data) pc->class_id = PCI_CLASS_STORAGE_EXPRESS; pc->vendor_id = PCI_VENDOR_ID_INTEL; pc->device_id = 0x5845; - pc->revision = 1; + pc->revision = 2; pc->is_express = 1; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);