From patchwork Tue Oct 13 14:25:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 529777 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 36E651402B7 for ; Wed, 14 Oct 2015 01:39:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=ThOXdRzC; dkim-atps=neutral Received: from localhost ([::1]:36339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm0jV-0004MY-Gy for incoming@patchwork.ozlabs.org; Tue, 13 Oct 2015 10:39:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm0Y0-0008LC-7f for qemu-devel@nongnu.org; Tue, 13 Oct 2015 10:27:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm0Xz-0000Yo-E8 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 10:27:24 -0400 Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:33904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm0Xz-0000Yj-8x for qemu-devel@nongnu.org; Tue, 13 Oct 2015 10:27:23 -0400 Received: by padhy16 with SMTP id hy16so23036066pad.1 for ; Tue, 13 Oct 2015 07:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=hCIKG6C1/UYzI6FdVRMWbvRuRVDCZE7Dr/PVSeXirNg=; b=ThOXdRzCN2rOnru5oPTgmrUIZXKctkl5aQJ5uPKzoAkgiqMjQII0+lZrogU1KAFT+T jiDWcETfOls38vYbYsIPApQ9lFDZ3SXUPpPtBsvxuLFGPH8OqlvWzR758Fs4zKQ14en2 GrE/EvBqwOl/GyFiX0LHoFtXlnkREjL5vrrNys4HBh5gX0fLWbbvGcvyG7fFBtr8o9u0 XEYbC3JoB+TQooRGKH+qgGW+ufbVK7PzSwRkldNBuMRER3emdZpVT0IluzXJKRb0DYs/ 7zcOCeYtw7/L27npoWFvapClyxAYMxsbB0JqTJfyoMlUEvZYfqCDYY9pHobmKrCDruah d2OA== X-Received: by 10.66.248.10 with SMTP id yi10mr41597217pac.6.1444746442972; Tue, 13 Oct 2015 07:27:22 -0700 (PDT) Received: from localhost ([2a01:e35:8a71:51f0:3ea9:f4ff:fe4c:6bac]) by smtp.gmail.com with ESMTPSA id cn4sm4243533pbc.94.2015.10.13.07.27.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2015 07:27:22 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Tue, 13 Oct 2015 16:25:42 +0200 Message-Id: <1444746378-12338-16-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1444746378-12338-1-git-send-email-marcandre.lureau@redhat.com> References: <1444746378-12338-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::235 Cc: peter.maydell@linaro.org, drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PULL v3 15/51] ivshmem: remove useless ivshmem_update_irq() val argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau val isn't used in ivshmem_update_irq() function. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 19640bb..374ecff 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -123,7 +123,7 @@ static inline bool is_power_of_two(uint64_t x) { } /* accessing registers - based on rtl8139 */ -static void ivshmem_update_irq(IVShmemState *s, int val) +static void ivshmem_update_irq(IVShmemState *s) { PCIDevice *d = PCI_DEVICE(s); int isr; @@ -144,7 +144,7 @@ static void ivshmem_IntrMask_write(IVShmemState *s, uint32_t val) s->intrmask = val; - ivshmem_update_irq(s, val); + ivshmem_update_irq(s); } static uint32_t ivshmem_IntrMask_read(IVShmemState *s) @@ -162,7 +162,7 @@ static void ivshmem_IntrStatus_write(IVShmemState *s, uint32_t val) s->intrstatus = val; - ivshmem_update_irq(s, val); + ivshmem_update_irq(s); } static uint32_t ivshmem_IntrStatus_read(IVShmemState *s) @@ -172,7 +172,7 @@ static uint32_t ivshmem_IntrStatus_read(IVShmemState *s) /* reading ISR clears all interrupts */ s->intrstatus = 0; - ivshmem_update_irq(s, 0); + ivshmem_update_irq(s); return ret; }