From patchwork Fri Aug 14 15:02:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 507450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EFB6D140295 for ; Sat, 15 Aug 2015 01:10:29 +1000 (AEST) Received: from localhost ([::1]:46761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQGcm-0001ci-2h for incoming@patchwork.ozlabs.org; Fri, 14 Aug 2015 11:10:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQGVF-0003dx-Tg for qemu-devel@nongnu.org; Fri, 14 Aug 2015 11:02:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQGVD-0000Yv-Vn for qemu-devel@nongnu.org; Fri, 14 Aug 2015 11:02:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQGVD-0000Ye-Qr for qemu-devel@nongnu.org; Fri, 14 Aug 2015 11:02:39 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 6F682461E1; Fri, 14 Aug 2015 15:02:39 +0000 (UTC) Received: from localhost (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7EF2cXM001661; Fri, 14 Aug 2015 11:02:38 -0400 From: Stefan Hajnoczi To: Date: Fri, 14 Aug 2015 16:02:33 +0100 Message-Id: <1439564555-518-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1439564555-518-1-git-send-email-stefanha@redhat.com> References: <1439564555-518-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Peter Maydell , Dana Rubin , Stefan Hajnoczi , Shmulik Ladkani Subject: [Qemu-devel] [PULL 1/3] net/vmxnet3: Fix incorrect debug message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Dana Rubin From: Dana Rubin In commit 80da311d81, "net/vmxnet3: Fix RX TCP/UDP checksum on partially summed packets" a debug message was introduced in vmxnet3_rx_need_csum_calculate() for an unlikely input condition. The message accidentally printed 'len' variable instead of 'pkt_len'. Fix, providing the correct argument. Signed-off-by: Dana Rubin Signed-off-by: Shmulik Ladkani Message-id: 1438109090-18957-1-git-send-email-shmulik.ladkani@ravellosystems.com Signed-off-by: Stefan Hajnoczi --- hw/net/vmxnet3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 59b06b8..071feeb 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -927,9 +927,9 @@ static void vmxnet3_rx_need_csum_calculate(struct VmxnetRxPkt *pkt, /* Validate packet len: csum_start + scum_offset + length of csum field */ if (pkt_len < (vhdr->csum_start + vhdr->csum_offset + 2)) { - VMW_PKPRN("packet len:%d < csum_start(%d) + csum_offset(%d) + 2, " + VMW_PKPRN("packet len:%lu < csum_start(%d) + csum_offset(%d) + 2, " "cannot calculate checksum", - len, vhdr->csum_start, vhdr->csum_offset); + pkt_len, vhdr->csum_start, vhdr->csum_offset); return; }