| Message ID | 1436259656-24263-1-git-send-email-jasowang@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 07/07 17:00, Jason Wang wrote: > We should pass the size of packet instead of the remaining to > qemu_send_packet_async(). > > Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a > ("net/socket: Drop net_socket_can_send") > > Signed-off-by: Jason Wang <jasowang@redhat.com> Thanks! Reviewed-by: Fam Zheng <famz@redhat.com> > --- > net/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/socket.c b/net/socket.c > index c752696..b1e3b1c 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -213,7 +213,7 @@ static void net_socket_send(void *opaque) > if (s->index >= s->packet_len) { > s->index = 0; > s->state = 0; > - if (qemu_send_packet_async(&s->nc, s->buf, size, > + if (qemu_send_packet_async(&s->nc, s->buf, s->packet_len, > net_socket_send_completed) == 0) { > net_socket_read_poll(s, false); > break; > -- > 2.1.4 >
On Tue, Jul 07, 2015 at 05:00:56PM +0800, Jason Wang wrote: > We should pass the size of packet instead of the remaining to > qemu_send_packet_async(). > > Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a > ("net/socket: Drop net_socket_can_send") > > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > net/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan
diff --git a/net/socket.c b/net/socket.c index c752696..b1e3b1c 100644 --- a/net/socket.c +++ b/net/socket.c @@ -213,7 +213,7 @@ static void net_socket_send(void *opaque) if (s->index >= s->packet_len) { s->index = 0; s->state = 0; - if (qemu_send_packet_async(&s->nc, s->buf, size, + if (qemu_send_packet_async(&s->nc, s->buf, s->packet_len, net_socket_send_completed) == 0) { net_socket_read_poll(s, false); break;
We should pass the size of packet instead of the remaining to qemu_send_packet_async(). Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a ("net/socket: Drop net_socket_can_send") Signed-off-by: Jason Wang <jasowang@redhat.com> --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)