From patchwork Thu Jun 18 15:54:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Borntraeger X-Patchwork-Id: 486365 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EB4871401F0 for ; Fri, 19 Jun 2015 01:55:08 +1000 (AEST) Received: from localhost ([::1]:53476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5c9j-0002c6-7V for incoming@patchwork.ozlabs.org; Thu, 18 Jun 2015 11:55:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5c8s-0001RN-9h for qemu-devel@nongnu.org; Thu, 18 Jun 2015 11:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5c8o-0000qm-Vk for qemu-devel@nongnu.org; Thu, 18 Jun 2015 11:54:14 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:46560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5c8o-0000qD-L3 for qemu-devel@nongnu.org; Thu, 18 Jun 2015 11:54:10 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jun 2015 16:54:09 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 18 Jun 2015 16:54:08 +0100 X-Helo: d06dlp01.portsmouth.uk.ibm.com X-MailFrom: borntraeger@de.ibm.com X-RcptTo: qemu-stable@nongnu.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4EFF317D805F; Thu, 18 Jun 2015 16:55:13 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5IFs7MK23265292; Thu, 18 Jun 2015 15:54:07 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5IFs5nW003739; Thu, 18 Jun 2015 09:54:07 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t5IFs4n7003714; Thu, 18 Jun 2015 09:54:05 -0600 Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 25651) id CFFDC12243AA; Thu, 18 Jun 2015 17:54:04 +0200 (CEST) From: Christian Borntraeger To: qemu-devel Date: Thu, 18 Jun 2015 17:54:28 +0200 Message-Id: <1434642868-18685-1-git-send-email-borntraeger@de.ibm.com> X-Mailer: git-send-email 2.3.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15061815-0009-0000-0000-0000048E8187 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 195.75.94.108 Cc: qemu-stable@nongnu.org, Alexander Graf , Christian Borntraeger , v2.3.0@tuxmaker.boeblingen.de.ibm.com, #@tuxmaker.boeblingen.de.ibm.com, Cornelia Huck , Paolo Bonzini , Aurelien Jarno Subject: [Qemu-devel] [PATCH/RFC] s390x/ipl: Fix boot if no bootindex was specified X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced a regression: qemu-system-s390x -drive file=/home/cborntra/image.zhyp409,format=qcow2 does not boot, the bios states "No virtio-blk device found!" adding bootindex=1 does boot. The reason is that the uint32_t as return value will not do the right thing for the return -1 (default without bootindex). The bios itself, will interpret a 64bit -1 as autodetect (but it will interpret 32bit -1 as ccw device address ff.ff.ffff) Signed-off-by: Christian Borntraeger Cc: Paolo Bonzini Cc: Cornelia Huck Cc: qemu-stable@nongnu.org # v2.3.0 Tested-by: Aurelien Jarno Reviewed-by: Aurelien Jarno --- hw/s390x/ipl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 132004a..2e0a8b6 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -218,7 +218,7 @@ static Property s390_ipl_properties[] = { * - -1 if no valid boot device was found * - ccw id of the boot device otherwise */ -static uint32_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl) +static uint64_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl) { DeviceState *dev_st; @@ -248,7 +248,7 @@ static uint32_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl) return -1; out: - return ipl->cssid << 24 | ipl->ssid << 16 | ipl->devno; + return (uint32_t) (ipl->cssid << 24 | ipl->ssid << 16 | ipl->devno); } int s390_ipl_update_diag308(IplParameterBlock *iplb)