diff mbox

[01/13] target-mips: fix {D, W}RGPR in microMIPS

Message ID 1434117743-53520-2-git-send-email-yongbok.kim@imgtec.com
State New
Headers show

Commit Message

Yongbok Kim June 12, 2015, 2:02 p.m. UTC 
rt, rs were swapped

Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
 target-mips/translate.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Aurelien Jarno June 15, 2015, 11:16 a.m. UTC | #1 
On 2015-06-12 15:02, Yongbok Kim wrote:
> rt, rs were swapped
> 
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
> ---
>  target-mips/translate.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index f6ae0d3..d4a530d 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -12749,12 +12749,12 @@ static void gen_pool32axf (CPUMIPSState *env, DisasContext *ctx, int rt, int rs)
>          case RDPGPR:
>              check_cp0_enabled(ctx);
>              check_insn(ctx, ISA_MIPS32R2);
> -            gen_load_srsgpr(rt, rs);
> +            gen_load_srsgpr(rs, rt);
>              break;
>          case WRPGPR:
>              check_cp0_enabled(ctx);
>              check_insn(ctx, ISA_MIPS32R2);
> -            gen_store_srsgpr(rt, rs);
> +            gen_store_srsgpr(rs, rt);
>              break;
>          default:
>              goto pool32axf_invalid;

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Note however that your subject should be {RD,WR}PGPR to correctly match
both instructions.
Leon Alrae June 15, 2015, 4:19 p.m. UTC | #2 
On 12/06/2015 15:02, Yongbok Kim wrote:
> rt, rs were swapped
> 
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
> ---
>  target-mips/translate.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
diff mbox

Patch

diff --git a/target-mips/translate.c b/target-mips/translate.c
index f6ae0d3..d4a530d 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -12749,12 +12749,12 @@  static void gen_pool32axf (CPUMIPSState *env, DisasContext *ctx, int rt, int rs)
         case RDPGPR:
             check_cp0_enabled(ctx);
             check_insn(ctx, ISA_MIPS32R2);
-            gen_load_srsgpr(rt, rs);
+            gen_load_srsgpr(rs, rt);
             break;
         case WRPGPR:
             check_cp0_enabled(ctx);
             check_insn(ctx, ISA_MIPS32R2);
-            gen_store_srsgpr(rt, rs);
+            gen_store_srsgpr(rs, rt);
             break;
         default:
             goto pool32axf_invalid;