| Message ID | 1433193897-24110-4-git-send-email-aurelien@aurel32.net |
|---|---|
| State | New |
| Headers | show |
On 06/01/2015 02:24 PM, Aurelien Jarno wrote: > D(0x8400, BRXH, RSI, Z, 0, 0, 0, 0, bx32, 0, 0) > D(0x8500, BRXLE, RSI, Z, 0, 0, 0, 0, bx32, 0, 1) > D(0xec44, BRXHG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 0) > - D(0xec45, BRXHLE, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 1) > + D(0xec45, BRXLG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 1) > > /* CHECKSUM */ > C(0xb241, CKSM, RRE, Z, r1_o, ra2, new, r1_32, cksm, 0) > It seems to have changed names several times. Indeed, while it's BRXLG in PoO v8, it's been renamed BRXLEG in v10. r~
On 2015-06-01 18:33, Richard Henderson wrote: > On 06/01/2015 02:24 PM, Aurelien Jarno wrote: > > D(0x8400, BRXH, RSI, Z, 0, 0, 0, 0, bx32, 0, 0) > > D(0x8500, BRXLE, RSI, Z, 0, 0, 0, 0, bx32, 0, 1) > > D(0xec44, BRXHG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 0) > >- D(0xec45, BRXHLE, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 1) > >+ D(0xec45, BRXLG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 1) > > > > /* CHECKSUM */ > > C(0xb241, CKSM, RRE, Z, r1_o, ra2, new, r1_32, cksm, 0) > > > > It seems to have changed names several times. > > Indeed, while it's BRXLG in PoO v8, it's been renamed BRXLEG in v10. Ok. Then I'll drop this patch in the next version, and I'll try to remember this one next time I review the list of missing instructions.
diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 3955443..f83445a 100644 --- a/target-s390x/insn-data.def +++ b/target-s390x/insn-data.def @@ -120,7 +120,7 @@ D(0x8400, BRXH, RSI, Z, 0, 0, 0, 0, bx32, 0, 0) D(0x8500, BRXLE, RSI, Z, 0, 0, 0, 0, bx32, 0, 1) D(0xec44, BRXHG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 0) - D(0xec45, BRXHLE, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 1) + D(0xec45, BRXLG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 1) /* CHECKSUM */ C(0xb241, CKSM, RRE, Z, r1_o, ra2, new, r1_32, cksm, 0)
Use the same name than in PoP and binutils. Cc: Alexander Graf <agraf@suse.de> Cc: Richard Henderson <rth@twiddle.net> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> --- target-s390x/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)