From patchwork Wed May 27 15:07:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 477170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4A57C14027C for ; Thu, 28 May 2015 01:09:05 +1000 (AEST) Received: from localhost ([::1]:54330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxcx5-0000FP-AP for incoming@patchwork.ozlabs.org; Wed, 27 May 2015 11:09:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxcwO-0007Wl-Lh for qemu-devel@nongnu.org; Wed, 27 May 2015 11:08:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxcwK-0004JJ-Oz for qemu-devel@nongnu.org; Wed, 27 May 2015 11:08:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxcwK-0004J4-Hw for qemu-devel@nongnu.org; Wed, 27 May 2015 11:08:16 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4RF8GPT028513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 May 2015 11:08:16 -0400 Received: from localhost.localdomain.com (vpn1-7-29.ams2.redhat.com [10.36.7.29]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4RF87Yc012452; Wed, 27 May 2015 11:08:14 -0400 From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Wed, 27 May 2015 16:07:52 +0100 Message-Id: <1432739276-10452-5-git-send-email-berrange@redhat.com> In-Reply-To: <1432739276-10452-1-git-send-email-berrange@redhat.com> References: <1432739276-10452-1-git-send-email-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [Qemu-devel] [PATCH v5 4/8] qom: add helper method for getting user objects root X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add object_get_objects_root() method which is a convience for obtaining the Object * located at /objects in the object composition tree. Convert existing code over to use the new API where appropriate. Signed-off-by: Daniel P. Berrange --- include/qom/object.h | 12 ++++++++++++ iothread.c | 4 +--- numa.c | 2 +- qmp.c | 6 +++--- qom/object.c | 5 +++++ 5 files changed, 22 insertions(+), 7 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index d2d7748..d30c68c 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1026,6 +1026,18 @@ const char *object_property_get_type(Object *obj, const char *name, */ Object *object_get_root(void); + +/** + * object_get_objects_root: + * + * Get the container object that holds user created + * object instances. This is the object at path + * "/objects" + * + * Returns: the user object container + */ +Object *object_get_objects_root(void); + /** * object_get_canonical_path_component: * diff --git a/iothread.c b/iothread.c index 0416fc4..98dcdf9 100644 --- a/iothread.c +++ b/iothread.c @@ -19,8 +19,6 @@ #include "qmp-commands.h" #include "qemu/error-report.h" -#define IOTHREADS_PATH "/objects" - typedef ObjectClass IOThreadClass; #define IOTHREAD_GET_CLASS(obj) \ @@ -153,7 +151,7 @@ IOThreadInfoList *qmp_query_iothreads(Error **errp) { IOThreadInfoList *head = NULL; IOThreadInfoList **prev = &head; - Object *container = container_get(object_get_root(), IOTHREADS_PATH); + Object *container = object_get_objects_root(); object_child_foreach(container, query_one_iothread, &prev); return head; diff --git a/numa.c b/numa.c index c975fb2..b14a5c1 100644 --- a/numa.c +++ b/numa.c @@ -486,7 +486,7 @@ MemdevList *qmp_query_memdev(Error **errp) Object *obj; MemdevList *list = NULL; - obj = object_resolve_path("/objects", NULL); + obj = object_get_objects_root(); if (obj == NULL) { return NULL; } diff --git a/qmp.c b/qmp.c index 3f5dfe3..fa013e3 100644 --- a/qmp.c +++ b/qmp.c @@ -651,7 +651,7 @@ void object_add(const char *type, const char *id, const QDict *qdict, } } - object_property_add_child(container_get(object_get_root(), "/objects"), + object_property_add_child(object_get_objects_root(), id, obj, &local_err); if (local_err) { goto out; @@ -659,7 +659,7 @@ void object_add(const char *type, const char *id, const QDict *qdict, user_creatable_complete(obj, &local_err); if (local_err) { - object_property_del(container_get(object_get_root(), "/objects"), + object_property_del(object_get_objects_root(), id, &error_abort); goto out; } @@ -706,7 +706,7 @@ void qmp_object_del(const char *id, Error **errp) Object *container; Object *obj; - container = container_get(object_get_root(), "/objects"); + container = object_get_objects_root(); obj = object_resolve_path_component(container, id); if (!obj) { error_setg(errp, "object id not found"); diff --git a/qom/object.c b/qom/object.c index b8dff43..baeece2 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1054,6 +1054,11 @@ Object *object_get_root(void) return root; } +Object *object_get_objects_root(void) +{ + return container_get(object_get_root(), "/objects"); +} + static void object_get_child_property(Object *obj, Visitor *v, void *opaque, const char *name, Error **errp) {