From patchwork Tue May 26 05:38:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 476376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 81A651402B5 for ; Tue, 26 May 2015 15:38:41 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=UOd4aS03; dkim-atps=neutral Received: from localhost ([::1]:46010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx7ZW-00041d-0E for incoming@patchwork.ozlabs.org; Tue, 26 May 2015 01:38:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx7ZH-0003kE-HM for qemu-devel@nongnu.org; Tue, 26 May 2015 01:38:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx7ZD-0007hd-Ac for qemu-devel@nongnu.org; Tue, 26 May 2015 01:38:23 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:35125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx7ZD-0007hS-3S for qemu-devel@nongnu.org; Tue, 26 May 2015 01:38:19 -0400 Received: by pacwv17 with SMTP id wv17so84412233pac.2 for ; Mon, 25 May 2015 22:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=3nhAFvgV3fJXuo83nMx6zOCbd1Z3y1E34AmCkRQOC9U=; b=UOd4aS03RB+u9M58Uy6Lma/w3cc4kjTCUpxu7HLVqpCBre4IJEyIUCoWl6io7o62LP p49sbiJDwtSsyoFuFFkWoDZ6Bk/X/eifngVVqkLaK40jTswibmvx9NuO+Z81H87WpCnT vSymkrjc4CzdmxYb6Pb7FQ0L4+BMiN8oZoFeGGyXOR9V+iq580Ta62eG3BQi3eP7I5gO V2gXBFZYgxGSTOzSt+Fr7pyJNTrr81EMaSMU5n5ItzL7pLqau2F28zByIilM+zKIB6Dm hBpL0EUTrJ0KAI+bpTFGo9tXF5xFg1PUJ7LVZwqqvWzquJOU12cTVvHNa008vC5ehfDP +bNg== X-Received: by 10.66.120.47 with SMTP id kz15mr45350536pab.20.1432618697407; Mon, 25 May 2015 22:38:17 -0700 (PDT) Received: from pcrost-laptop.hsd1.ca.comcast.net (c-24-5-157-48.hsd1.ca.comcast.net. [24.5.157.48]) by mx.google.com with ESMTPSA id af5sm11651026pbc.90.2015.05.25.22.38.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 May 2015 22:38:16 -0700 (PDT) From: Peter Crosthwaite X-Google-Original-From: Peter Crosthwaite To: qemu-devel@nongnu.org Date: Mon, 25 May 2015 22:38:06 -0700 Message-Id: <1432618686-16077-1-git-send-email-crosthwaite.peter@gmail.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22e Cc: pbonzini@redhat.com, Gerd Hoffmann , Peter Crosthwaite Subject: [Qemu-devel] [PATCH] Makefile.target: set master BUILD_DIR X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org make can be invoked in the individual build dirs to build an individual target or just a single file of a target. e.g. touch translate-all.c make -C microblazeel-softmmu translate-all.o There is however a small bug when using the pixman submodule. config-host.mak will ref BUILD_DIR for the pixman -I CFLAGS: grep BUILD_DIR config-host.mak QEMU_CFLAGS=-I$(SRC_PATH)/pixman/pixman -I$(BUILD_DIR)/pixman/pixman ... This causes a build failure as -I/pixman/pixman (BUILD_DIR=="") will not be found. BUILD_DIR is usually set by the top level Makefile. Just lazy-set it in Makefile.target to the parent directory. Granted, this will not work if the pixman submodule is not prebuilt, but it at least means you can do incremental partial builds once you have done your initial full build (or attempt) from the top level. The next step would be refactor make infrastructure to rebuild pixman on a submake like the one above. Cc: Gerd Hoffmann Signed-off-by: Peter Crosthwaite --- Pixman is the only config-host.mak user of BUILD dir so maybe there is a pixman specific solution out there too? --- Makefile.target | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.target b/Makefile.target index 3e861c8..ec5b92c 100644 --- a/Makefile.target +++ b/Makefile.target @@ -1,5 +1,7 @@ # -*- Mode: makefile -*- +BUILD_DIR?=$(CURDIR)/.. + include ../config-host.mak include config-target.mak include config-devices.mak