Message ID | 1430335224-6716-5-git-send-email-mdroth@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
On 29/04/2015 21:20, Michael Roth wrote: > DRC objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> > --- > hw/ppc/spapr_iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index a14cdc4..79e998b 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -182,6 +182,7 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn, > > snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); > object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); > + object_unref(OBJECT(tcet)); > > object_property_set_bool(OBJECT(tcet), true, "realized", NULL); > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
On Wed, Apr 29, 2015 at 02:20:13PM -0500, Michael Roth wrote: > DRC objects attach themselves to an owner as a child ^^^ Copy and paste error in the commit message. > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> But otherwise, Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/ppc/spapr_iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index a14cdc4..79e998b 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -182,6 +182,7 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn, > > snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); > object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); > + object_unref(OBJECT(tcet)); > > object_property_set_bool(OBJECT(tcet), true, "realized", NULL); >
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index a14cdc4..79e998b 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -182,6 +182,7 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn, snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); + object_unref(OBJECT(tcet)); object_property_set_bool(OBJECT(tcet), true, "realized", NULL);
DRC objects attach themselves to an owner as a child property. unref afterward to allow them to be finalized when their owner is finalized. Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> --- hw/ppc/spapr_iommu.c | 1 + 1 file changed, 1 insertion(+)