| Message ID | 1429246120-29439-8-git-send-email-jasowang@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Fri, 17 Apr 2015 12:48:31 +0800 Jason Wang <jasowang@redhat.com> wrote: > There's no need to use vector 0 for invalid virtqueue. So this patch s/There's no need/It's a bad idea/ > changes to use VIRTIO_NO_VECTOR instead. s/use/using/ > > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Alexander Graf <agraf@suse.de> > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > hw/s390x/virtio-ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
On 04/17/2015 07:31 PM, Cornelia Huck wrote: > On Fri, 17 Apr 2015 12:48:31 +0800 > Jason Wang <jasowang@redhat.com> wrote: > >> There's no need to use vector 0 for invalid virtqueue. So this patch > s/There's no need/It's a bad idea/ > >> changes to use VIRTIO_NO_VECTOR instead. > s/use/using/ > >> Cc: Michael S. Tsirkin <mst@redhat.com> >> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> >> CC: Christian Borntraeger <borntraeger@de.ibm.com> >> Cc: Richard Henderson <rth@twiddle.net> >> Cc: Alexander Graf <agraf@suse.de> >> Signed-off-by: Jason Wang <jasowang@redhat.com> >> --- >> hw/s390x/virtio-ccw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> > Will change the log as you've suggested. Thanks.
On 04/17/2015 07:31 PM, Cornelia Huck wrote: > On Fri, 17 Apr 2015 12:48:31 +0800 > Jason Wang <jasowang@redhat.com> wrote: > >> There's no need to use vector 0 for invalid virtqueue. So this patch > s/There's no need/It's a bad idea/ > >> changes to use VIRTIO_NO_VECTOR instead. > s/use/using/ > >> Cc: Michael S. Tsirkin <mst@redhat.com> >> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> >> CC: Christian Borntraeger <borntraeger@de.ibm.com> >> Cc: Richard Henderson <rth@twiddle.net> >> Cc: Alexander Graf <agraf@suse.de> >> Signed-off-by: Jason Wang <jasowang@redhat.com> >> --- >> hw/s390x/virtio-ccw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> > > Will correct the log. Thanks
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index d32ecaf..0434f56 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -281,7 +281,7 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align, virtio_queue_set_addr(vdev, index, addr); if (!addr) { - virtio_queue_set_vector(vdev, index, 0); + virtio_queue_set_vector(vdev, index, VIRTIO_NO_VECTOR); } else { /* Fail if we don't have a big enough queue. */ /* TODO: Add interface to handle vring.num changing */
There's no need to use vector 0 for invalid virtqueue. So this patch changes to use VIRTIO_NO_VECTOR instead. Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> CC: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Alexander Graf <agraf@suse.de> Signed-off-by: Jason Wang <jasowang@redhat.com> --- hw/s390x/virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)