diff mbox

[for-2.3?,4/7] tests/tcg: Fix running x86_64 tests

Message ID 1428777292-24628-5-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber April 11, 2015, 6:34 p.m. UTC
When ARCH != i386, the wrong test target was being added to the list of
tests to run. Fix this to have test-x86_64 run as well.

Note that test-x86_64 produces two build warnings on gcc 4.8.3, but we
don't use -Werror for these tests:

  test-i386.c:2110:1: warning: specifying vector types with __attribute__ ((mode)) is deprecated [-Wattributes]
   typedef int __m64 __attribute__ ((__mode__ (__V2SI__)));
  test-i386.c:2110:1: warning: use __attribute__ ((vector_size)) instead [-Wattributes]

  test-i386.c:2111:1: warning: specifying vector types with __attribute__ ((mode)) is deprecated [-Wattributes]
   typedef float __m128 __attribute__ ((__mode__(__V4SF__)));
  test-i386.c:2111:1: warning: use __attribute__ ((vector_size)) instead [-Wattributes]

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 tests/tcg/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Bennée April 13, 2015, 3:35 p.m. UTC | #1
Andreas Färber <afaerber@suse.de> writes:

> When ARCH != i386, the wrong test target was being added to the list of
> tests to run. Fix this to have test-x86_64 run as well.
>
> Note that test-x86_64 produces two build warnings on gcc 4.8.3, but we
> don't use -Werror for these tests:
>
>   test-i386.c:2110:1: warning: specifying vector types with __attribute__ ((mode)) is deprecated [-Wattributes]
>    typedef int __m64 __attribute__ ((__mode__ (__V2SI__)));
>   test-i386.c:2110:1: warning: use __attribute__ ((vector_size)) instead [-Wattributes]
>
>   test-i386.c:2111:1: warning: specifying vector types with __attribute__ ((mode)) is deprecated [-Wattributes]
>    typedef float __m128 __attribute__ ((__mode__(__V4SF__)));
>   test-i386.c:2111:1: warning: use __attribute__ ((vector_size)) instead [-Wattributes]
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/tcg/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
> index d79e0bb..ab1055f 100644
> --- a/tests/tcg/Makefile
> +++ b/tests/tcg/Makefile
> @@ -29,7 +29,7 @@ I386_TESTS=hello-i386 \
>  
>  # native i386 compilers sometimes are not biarch.  assume cross-compilers are
>  ifneq ($(ARCH),i386)
> -I386_TESTS+=run-test-x86_64
> +I386_TESTS+=test-x86_64
>  endif
>  
>  TESTS = test_path
diff mbox

Patch

diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
index d79e0bb..ab1055f 100644
--- a/tests/tcg/Makefile
+++ b/tests/tcg/Makefile
@@ -29,7 +29,7 @@  I386_TESTS=hello-i386 \
 
 # native i386 compilers sometimes are not biarch.  assume cross-compilers are
 ifneq ($(ARCH),i386)
-I386_TESTS+=run-test-x86_64
+I386_TESTS+=test-x86_64
 endif
 
 TESTS = test_path