diff mbox

[qemu] qemu-options: Add documentation about PPC64's "-cpu compat" option

Message ID 1427955971-8895-1-git-send-email-aik@ozlabs.ru
State New
Headers show

Commit Message

Alexey Kardashevskiy April 2, 2015, 6:26 a.m. UTC
Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
client-architecture-support patchset) there is a "compat" option
of "-cpu". However it was not documented at all and this is what this
patch is trying to do.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 qemu-options.hx | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Alexander Graf April 7, 2015, 8:43 p.m. UTC | #1
On 04/02/2015 08:26 AM, Alexey Kardashevskiy wrote:
> Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
> client-architecture-support patchset) there is a "compat" option
> of "-cpu". However it was not documented at all and this is what this
> patch is trying to do.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>   qemu-options.hx | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index c513352..bd15214 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -84,11 +84,20 @@ HXCOMM Deprecated by -machine
>   DEF("M", HAS_ARG, QEMU_OPTION_M, "", QEMU_ARCH_ALL)
>   
>   DEF("cpu", HAS_ARG, QEMU_OPTION_cpu,
> -    "-cpu cpu        select CPU ('-cpu help' for list)\n", QEMU_ARCH_ALL)
> +    "-cpu cpu,[compat=MODE]\n"
> +    "                select CPU ('-cpu help' for list)\n"
> +    "                compat= processor compatibility mode (PPC64 only)\n",
> +        QEMU_ARCH_ALL)

Shouldn't there be a way to show this only for the ppc64 target?


Alex

>   STEXI
>   @item -cpu @var{model}
>   @findex -cpu
>   Select CPU model (@code{-cpu help} for list and additional feature selection)
> +@table @option
> +@item compat=power6|power7|power8
> +(PPC64 only)
> +Enables architecture compatibility mode. "power6" enables PowerISA 2.05,
> +"power7" - 2.06, "power8" - 2.07.
> +@end table
>   ETEXI
>   
>   DEF("smp", HAS_ARG, QEMU_OPTION_smp,
Alexey Kardashevskiy April 8, 2015, 1:45 a.m. UTC | #2
On 04/08/2015 06:43 AM, Alexander Graf wrote:
> On 04/02/2015 08:26 AM, Alexey Kardashevskiy wrote:
>> Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
>> client-architecture-support patchset) there is a "compat" option
>> of "-cpu". However it was not documented at all and this is what this
>> patch is trying to do.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>   qemu-options.hx | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index c513352..bd15214 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -84,11 +84,20 @@ HXCOMM Deprecated by -machine
>>   DEF("M", HAS_ARG, QEMU_OPTION_M, "", QEMU_ARCH_ALL)
>>   DEF("cpu", HAS_ARG, QEMU_OPTION_cpu,
>> -    "-cpu cpu        select CPU ('-cpu help' for list)\n", QEMU_ARCH_ALL)
>> +    "-cpu cpu,[compat=MODE]\n"
>> +    "                select CPU ('-cpu help' for list)\n"
>> +    "                compat= processor compatibility mode (PPC64 only)\n",
>> +        QEMU_ARCH_ALL)
>
> Shouldn't there be a way to show this only for the ppc64 target?


I do not really know, I did not dig deep. I just saw "Intel IOMMU (VT-d)" 
in "qemu-system-ppc64 --help" output and concluded there is no easy way.



>
>
> Alex
>
>>   STEXI
>>   @item -cpu @var{model}
>>   @findex -cpu
>>   Select CPU model (@code{-cpu help} for list and additional feature
>> selection)
>> +@table @option
>> +@item compat=power6|power7|power8
>> +(PPC64 only)
>> +Enables architecture compatibility mode. "power6" enables PowerISA 2.05,
>> +"power7" - 2.06, "power8" - 2.07.
>> +@end table
>>   ETEXI
>>   DEF("smp", HAS_ARG, QEMU_OPTION_smp,
>
David Gibson April 8, 2015, 2:49 a.m. UTC | #3
On Thu, Apr 02, 2015 at 05:26:11PM +1100, Alexey Kardashevskiy wrote:
> Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
> client-architecture-support patchset) there is a "compat" option
> of "-cpu". However it was not documented at all and this is what this
> patch is trying to do.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

Merged into my spapr-next branch.
Alexander Graf April 8, 2015, 6:29 a.m. UTC | #4
> Am 08.04.2015 um 03:45 schrieb Alexey Kardashevskiy <aik@ozlabs.ru>:
> 
>> On 04/08/2015 06:43 AM, Alexander Graf wrote:
>>> On 04/02/2015 08:26 AM, Alexey Kardashevskiy wrote:
>>> Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
>>> client-architecture-support patchset) there is a "compat" option
>>> of "-cpu". However it was not documented at all and this is what this
>>> patch is trying to do.
>>> 
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>>  qemu-options.hx | 11 ++++++++++-
>>>  1 file changed, 10 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/qemu-options.hx b/qemu-options.hx
>>> index c513352..bd15214 100644
>>> --- a/qemu-options.hx
>>> +++ b/qemu-options.hx
>>> @@ -84,11 +84,20 @@ HXCOMM Deprecated by -machine
>>>  DEF("M", HAS_ARG, QEMU_OPTION_M, "", QEMU_ARCH_ALL)
>>>  DEF("cpu", HAS_ARG, QEMU_OPTION_cpu,
>>> -    "-cpu cpu        select CPU ('-cpu help' for list)\n", QEMU_ARCH_ALL)
>>> +    "-cpu cpu,[compat=MODE]\n"
>>> +    "                select CPU ('-cpu help' for list)\n"
>>> +    "                compat= processor compatibility mode (PPC64 only)\n",
>>> +        QEMU_ARCH_ALL)
>> 
>> Shouldn't there be a way to show this only for the ppc64 target?
> 
> 
> I do not really know, I did not dig deep. I just saw "Intel IOMMU (VT-d)" in "qemu-system-ppc64 --help" output and concluded there is no easy way.

Please dig again :).

Alex
diff mbox

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index c513352..bd15214 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -84,11 +84,20 @@  HXCOMM Deprecated by -machine
 DEF("M", HAS_ARG, QEMU_OPTION_M, "", QEMU_ARCH_ALL)
 
 DEF("cpu", HAS_ARG, QEMU_OPTION_cpu,
-    "-cpu cpu        select CPU ('-cpu help' for list)\n", QEMU_ARCH_ALL)
+    "-cpu cpu,[compat=MODE]\n"
+    "                select CPU ('-cpu help' for list)\n"
+    "                compat= processor compatibility mode (PPC64 only)\n",
+        QEMU_ARCH_ALL)
 STEXI
 @item -cpu @var{model}
 @findex -cpu
 Select CPU model (@code{-cpu help} for list and additional feature selection)
+@table @option
+@item compat=power6|power7|power8
+(PPC64 only)
+Enables architecture compatibility mode. "power6" enables PowerISA 2.05,
+"power7" - 2.06, "power8" - 2.07.
+@end table
 ETEXI
 
 DEF("smp", HAS_ARG, QEMU_OPTION_smp,