diff mbox

Use $(MAKE) for recursive make

Message ID 1427911118-21905-1-git-send-email-emaste@freebsd.org
State New
Headers show

Commit Message

Ed Maste April 1, 2015, 5:58 p.m. UTC
On BSDs "make" is typically BSD make, while "gmake" is GNU make.

Signed-off-by: Ed Maste <emaste@freebsd.org>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Weil April 1, 2015, 6:45 p.m. UTC | #1
Am 01.04.2015 um 19:58 schrieb Ed Maste:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
>   Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 88bce56..ee40397 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,8 @@ distclean: clean
>   	rm -rf $$d || exit 1 ; \
>           done
>   	rm -Rf .sdk
> -	if test -f pixman/config.log; then make -C pixman distclean; fi
> -	if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> +	if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> +	if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
>   
>   KEYMAPS=da     en-gb  et  fr     fr-ch  is  lt  modifiers  no  pt-br  sv \
>   ar      de     en-us  fi  fr-be  hr     it  lv  nl         pl  ru     th \

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Fam Zheng April 2, 2015, 3:16 a.m. UTC | #2
On Wed, 04/01 20:45, Stefan Weil wrote:
> Am 01.04.2015 um 19:58 schrieb Ed Maste:
> >On BSDs "make" is typically BSD make, while "gmake" is GNU make.
> >
> >Signed-off-by: Ed Maste <emaste@freebsd.org>
> >---
> >  Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/Makefile b/Makefile
> >index 88bce56..ee40397 100644
> >--- a/Makefile
> >+++ b/Makefile
> >@@ -331,8 +331,8 @@ distclean: clean
> >  	rm -rf $$d || exit 1 ; \
> >          done
> >  	rm -Rf .sdk
> >-	if test -f pixman/config.log; then make -C pixman distclean; fi
> >-	if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> >+	if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> >+	if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
> >  KEYMAPS=da     en-gb  et  fr     fr-ch  is  lt  modifiers  no  pt-br  sv \
> >  ar      de     en-us  fi  fr-be  hr     it  lv  nl         pl  ru     th \
> 
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
> 
> 

One more occasion below:

	$(INSTALLER): $(SRC_PATH)/qemu.nsi
		make install prefix=${INSTDIR}

But this is already helpful:

Reviewed-by: Fam Zheng <famz@redhat.com>
Stefan Hajnoczi April 2, 2015, 8:58 a.m. UTC | #3
On Wed, Apr 01, 2015 at 01:58:38PM -0400, Ed Maste wrote:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
> 
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Same on Solaris, if I remember correctly.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Paolo Bonzini April 2, 2015, 1:56 p.m. UTC | #4
On 01/04/2015 19:58, Ed Maste wrote:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
> 
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 88bce56..ee40397 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,8 @@ distclean: clean
>  	rm -rf $$d || exit 1 ; \
>          done
>  	rm -Rf .sdk
> -	if test -f pixman/config.log; then make -C pixman distclean; fi
> -	if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> +	if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> +	if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
>  
>  KEYMAPS=da     en-gb  et  fr     fr-ch  is  lt  modifiers  no  pt-br  sv \
>  ar      de     en-us  fi  fr-be  hr     it  lv  nl         pl  ru     th \
> 

Applied, thanks.

Paolo
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 88bce56..ee40397 100644
--- a/Makefile
+++ b/Makefile
@@ -331,8 +331,8 @@  distclean: clean
 	rm -rf $$d || exit 1 ; \
         done
 	rm -Rf .sdk
-	if test -f pixman/config.log; then make -C pixman distclean; fi
-	if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
+	if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
+	if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
 
 KEYMAPS=da     en-gb  et  fr     fr-ch  is  lt  modifiers  no  pt-br  sv \
 ar      de     en-us  fi  fr-be  hr     it  lv  nl         pl  ru     th \