From patchwork Thu Mar 19 19:01:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 452175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 53FFB14007F for ; Fri, 20 Mar 2015 06:09:14 +1100 (AEDT) Received: from localhost ([::1]:40756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYfoe-0004S1-66 for incoming@patchwork.ozlabs.org; Thu, 19 Mar 2015 15:09:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYfhQ-0006qt-HW for qemu-devel@nongnu.org; Thu, 19 Mar 2015 15:01:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYfhP-0005b6-Bt for qemu-devel@nongnu.org; Thu, 19 Mar 2015 15:01:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYfhP-0005ap-3S for qemu-devel@nongnu.org; Thu, 19 Mar 2015 15:01:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2JJ1eIY010654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Mar 2015 15:01:41 -0400 Received: from scv.usersys.redhat.com (vpn-53-166.rdu2.redhat.com [10.10.53.166]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2JJ1cJn013020; Thu, 19 Mar 2015 15:01:40 -0400 From: John Snow To: qemu-devel@nongnu.org Date: Thu, 19 Mar 2015 15:01:36 -0400 Message-Id: <1426791697-17895-4-git-send-email-jsnow@redhat.com> In-Reply-To: <1426791697-17895-1-git-send-email-jsnow@redhat.com> References: <1426791697-17895-1-git-send-email-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: peter.maydell@linaro.org, John Snow , stefanha@redhat.com Subject: [Qemu-devel] [PATCH v3 3/4] configure: silence glib unknown attribute __alloc_size__ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The glib headers use GCC attributes. Unfortunately the __GNUC__ and __GNUC_MINOR__ version macros are also defined by clang, but clang doesn't support the same attributes as GCC. clang 3.5.0 does not support the __alloc_size__ attribute: https://github.com/llvm-mirror/clang/commit/c047507a9a79e89fc8339e074fa72822a7e7ea73 The following warning is produced: gstrfuncs.h:257:44: warning: unknown attribute '__alloc_size__' ignored [-Wunknown-attributes] G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(2); gmacros.h:67:45: note: expanded from macro 'G_GNUC_ALLOC_SIZE' #define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x))) This patch checks whether glib headers cause warnings and disables -Wunknown-attributes if it is able to. Signed-off-by: Stefan Hajnoczi Signed-off-by: John Snow --- configure | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/configure b/configure index 9a0e4ef..fbcbf50 100755 --- a/configure +++ b/configure @@ -2792,6 +2792,18 @@ if ! $pkg_config --atleast-version=2.38 glib-2.0; then glib_subprocess=no fi +# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage +cat > $TMPC << EOF +#include +int main(void) { return 0; } +EOF +if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then + if cc_has_warning_flag "-Wno-unknown-attributes"; then + glib_cflags="-Wno-unknown-attributes $glib_cflags" + CFLAGS="-Wno-unknown-attributes $CFLAGS" + fi +fi + ########################################## # SHA command probe for modules if test "$modules" = yes; then