diff mbox

[RFC,v1,2/2] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

Message ID 1426275418-8411-3-git-send-email-konrad.wilk@oracle.com
State New
Headers show

Commit Message

Konrad Rzeszutek Wilk March 13, 2015, 7:36 p.m. UTC 
.errors - as it will most likely have the proper error value.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen-hvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Stabellini March 16, 2015, 10:14 a.m. UTC | #1 
On Fri, 13 Mar 2015, Konrad Rzeszutek Wilk wrote:
> .errors - as it will most likely have the proper error value.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>


>  xen-hvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen-hvm.c b/xen-hvm.c
> index 7548794..3d6fed3 100644
> --- a/xen-hvm.c
> +++ b/xen-hvm.c
> @@ -348,7 +348,7 @@ go_physmap:
>          rc = xc_domain_add_to_physmap(xen_xc, xen_domid, XENMAPSPACE_gmfn, idx, gpfn);
>          if (rc) {
>              DPRINTF("add_to_physmap MFN %"PRI_xen_pfn" to PFN %"
> -                    PRI_xen_pfn" failed: %d\n", idx, gpfn, rc);
> +                    PRI_xen_pfn" failed: %d (errno: %d)\n", idx, gpfn, rc, errno);
>              return -rc;
>          }
>      }
> @@ -425,7 +425,7 @@ static int xen_remove_from_physmap(XenIOState *state,
>          rc = xc_domain_add_to_physmap(xen_xc, xen_domid, XENMAPSPACE_gmfn, idx, gpfn);
>          if (rc) {
>              fprintf(stderr, "add_to_physmap MFN %"PRI_xen_pfn" to PFN %"
> -                    PRI_xen_pfn" failed: %d\n", idx, gpfn, rc);
> +                    PRI_xen_pfn" failed: %d (errno: %d)\n", idx, gpfn, rc, errno);
>              return -rc;
>          }
>      }
> -- 
> 2.1.0
>
diff mbox

Patch

diff --git a/xen-hvm.c b/xen-hvm.c
index 7548794..3d6fed3 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -348,7 +348,7 @@  go_physmap:
         rc = xc_domain_add_to_physmap(xen_xc, xen_domid, XENMAPSPACE_gmfn, idx, gpfn);
         if (rc) {
             DPRINTF("add_to_physmap MFN %"PRI_xen_pfn" to PFN %"
-                    PRI_xen_pfn" failed: %d\n", idx, gpfn, rc);
+                    PRI_xen_pfn" failed: %d (errno: %d)\n", idx, gpfn, rc, errno);
             return -rc;
         }
     }
@@ -425,7 +425,7 @@  static int xen_remove_from_physmap(XenIOState *state,
         rc = xc_domain_add_to_physmap(xen_xc, xen_domid, XENMAPSPACE_gmfn, idx, gpfn);
         if (rc) {
             fprintf(stderr, "add_to_physmap MFN %"PRI_xen_pfn" to PFN %"
-                    PRI_xen_pfn" failed: %d\n", idx, gpfn, rc);
+                    PRI_xen_pfn" failed: %d (errno: %d)\n", idx, gpfn, rc, errno);
             return -rc;
         }
     }