| Message ID | 1425569930-6660-5-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Thu, 5 Mar 2015 12:38:48 -0300 Eduardo Habkost <ehabkost@redhat.com> wrote: > Rename the function so that the reason for its existence is clearer: it > does x86-specific initialization of TCG structures. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > target-i386/cpu.c | 2 +- > target-i386/cpu.h | 2 +- > target-i386/translate.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 50907d0..b4e70d3 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -2883,7 +2883,7 @@ static void x86_cpu_initfn(Object *obj) > /* init various static tables used in TCG mode */ > if (tcg_enabled() && !inited) { > inited = 1; > - optimize_flags_init(); > + tcg_x86_init(); > } how about moving 'inited' handling inside of tcg_x86_init() along with renaming? > } > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index 0638d24..52b460a 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -1228,7 +1228,7 @@ static inline target_long lshift(target_long x, int n) > #define ST1 ST(1) > > /* translate.c */ > -void optimize_flags_init(void); > +void tcg_x86_init(void); > > #include "exec/cpu-all.h" > #include "svm.h" > diff --git a/target-i386/translate.c b/target-i386/translate.c > index 094cec0..f19f20f 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -7852,7 +7852,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, > return s->pc; > } > > -void optimize_flags_init(void) > +void tcg_x86_init(void) > { > static const char reg_names[CPU_NB_REGS][4] = { > #ifdef TARGET_X86_64
On Thu, Mar 05, 2015 at 05:31:39PM +0100, Igor Mammedov wrote: > On Thu, 5 Mar 2015 12:38:48 -0300 > Eduardo Habkost <ehabkost@redhat.com> wrote: > > > Rename the function so that the reason for its existence is clearer: it > > does x86-specific initialization of TCG structures. > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > --- > > target-i386/cpu.c | 2 +- > > target-i386/cpu.h | 2 +- > > target-i386/translate.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 50907d0..b4e70d3 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -2883,7 +2883,7 @@ static void x86_cpu_initfn(Object *obj) > > /* init various static tables used in TCG mode */ > > if (tcg_enabled() && !inited) { > > inited = 1; > > - optimize_flags_init(); > > + tcg_x86_init(); > > } > how about moving 'inited' handling inside of tcg_x86_init() along with renaming? Makes sense, and it will help simplify patch 5/6. But I'll do that in a separate patch. > > > } > > > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > > index 0638d24..52b460a 100644 > > --- a/target-i386/cpu.h > > +++ b/target-i386/cpu.h > > @@ -1228,7 +1228,7 @@ static inline target_long lshift(target_long x, int n) > > #define ST1 ST(1) > > > > /* translate.c */ > > -void optimize_flags_init(void); > > +void tcg_x86_init(void); > > > > #include "exec/cpu-all.h" > > #include "svm.h" > > diff --git a/target-i386/translate.c b/target-i386/translate.c > > index 094cec0..f19f20f 100644 > > --- a/target-i386/translate.c > > +++ b/target-i386/translate.c > > @@ -7852,7 +7852,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, > > return s->pc; > > } > > > > -void optimize_flags_init(void) > > +void tcg_x86_init(void) > > { > > static const char reg_names[CPU_NB_REGS][4] = { > > #ifdef TARGET_X86_64 >
diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 50907d0..b4e70d3 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2883,7 +2883,7 @@ static void x86_cpu_initfn(Object *obj) /* init various static tables used in TCG mode */ if (tcg_enabled() && !inited) { inited = 1; - optimize_flags_init(); + tcg_x86_init(); } } diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 0638d24..52b460a 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -1228,7 +1228,7 @@ static inline target_long lshift(target_long x, int n) #define ST1 ST(1) /* translate.c */ -void optimize_flags_init(void); +void tcg_x86_init(void); #include "exec/cpu-all.h" #include "svm.h" diff --git a/target-i386/translate.c b/target-i386/translate.c index 094cec0..f19f20f 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -7852,7 +7852,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, return s->pc; } -void optimize_flags_init(void) +void tcg_x86_init(void) { static const char reg_names[CPU_NB_REGS][4] = { #ifdef TARGET_X86_64
Rename the function so that the reason for its existence is clearer: it does x86-specific initialization of TCG structures. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- target-i386/cpu.c | 2 +- target-i386/cpu.h | 2 +- target-i386/translate.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)