iotests: Fix 061's reference output

As of commit dc523cd348c47372faa7271c9aab2030f94c290d, passing an unkown
option name for image creation no longer results in that option's name
printed. This affects iotest 061's output, fix it.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/061.out | 1 -
 1 file changed, 1 deletion(-)

Am 03.03.2015 um 20:57 hat Max Reitz geschrieben:
> As of commit dc523cd348c47372faa7271c9aab2030f94c290d, passing an unkown
> option name for image creation no longer results in that option's name
> printed. This affects iotest 061's output, fix it.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/061.out | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/061.out b/tests/qemu-iotests/061.out
> index e70f983..52f0a31 100644
> --- a/tests/qemu-iotests/061.out
> +++ b/tests/qemu-iotests/061.out
> @@ -287,7 +287,6 @@ Lazy refcounts only supported with compatibility level 1.1 and above (use compat
>  qemu-img: Error while amending options: Invalid argument
>  Unknown compatibility level 0.42.
>  qemu-img: Error while amending options: Invalid argument
> -qemu-img: Invalid parameter 'foo'
>  qemu-img: Invalid options for file format 'qcow2'
>  Changing the cluster size is not supported.
>  qemu-img: Error while amending options: Operation not supported

I think I would prefer a patch that primarily fixes the error message (I
would consider the recent change that removed the name of the unknown
option a usability regression that the test caught) and then changes the
test only as a byproduct.

Markus, throwing away the original error message like commit dc523cd3
does is almost always wrong. It's the callee that knows what exactly the
problem is; the caller may add context, but it rarely knows the details
better.

Kevin

Kevin Wolf <kwolf@redhat.com> writes:

> Am 03.03.2015 um 20:57 hat Max Reitz geschrieben:
>> As of commit dc523cd348c47372faa7271c9aab2030f94c290d, passing an unkown
>> option name for image creation no longer results in that option's name
>> printed. This affects iotest 061's output, fix it.
>> 
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>  tests/qemu-iotests/061.out | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/tests/qemu-iotests/061.out b/tests/qemu-iotests/061.out
>> index e70f983..52f0a31 100644
>> --- a/tests/qemu-iotests/061.out
>> +++ b/tests/qemu-iotests/061.out
>> @@ -287,7 +287,6 @@ Lazy refcounts only supported with compatibility
>> level 1.1 and above (use compat
>>  qemu-img: Error while amending options: Invalid argument
>>  Unknown compatibility level 0.42.
>>  qemu-img: Error while amending options: Invalid argument
>> -qemu-img: Invalid parameter 'foo'
>>  qemu-img: Invalid options for file format 'qcow2'
>>  Changing the cluster size is not supported.
>>  qemu-img: Error while amending options: Operation not supported
>
> I think I would prefer a patch that primarily fixes the error message (I
> would consider the recent change that removed the name of the unknown
> option a usability regression that the test caught) and then changes the
> test only as a byproduct.
>
> Markus, throwing away the original error message like commit dc523cd3
> does is almost always wrong. It's the callee that knows what exactly the
> problem is; the caller may add context, but it rarely knows the details
> better.

I know, but I occasionally screw one up anyway.  Fix sent: "[PATCH 0/2]
Unbreak qemu-img error messages and iotests".