| Message ID | 1425396538-16765-1-git-send-email-imammedo@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 03.03.2015 um 16:28 schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > --- > configure | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/configure b/configure > index 7ba4bcb..db79e0a 100755 > --- a/configure > +++ b/configure > @@ -2744,12 +2744,7 @@ fi > ########################################## > # glib support probe > > -if test "$mingw32" = yes; then > - # g_poll is required in order to integrate with the glib main loop. > - glib_req_ver=2.20 > -else > - glib_req_ver=2.12 > -fi > +glib_req_ver=2.22 > glib_modules=gthread-2.0 > if test "$modules" = yes; then > glib_modules="$glib_modules gmodule-2.0" A comment in the commit message (or even in file configure) why 2.22 is needed would be helpful (this applies also to other requirements). I typically face the problem that I want to run a build test on a platform which does not support the latest package versions (e. g. Debian stable or Windows). Then I usually try to lower the requirements until the feature which depends on that requirement is enabled. Especially for glib the requirements for Linux, Mac and Windows might also differ. Regards Stefan
diff --git a/configure b/configure index 7ba4bcb..db79e0a 100755 --- a/configure +++ b/configure @@ -2744,12 +2744,7 @@ fi ########################################## # glib support probe -if test "$mingw32" = yes; then - # g_poll is required in order to integrate with the glib main loop. - glib_req_ver=2.20 -else - glib_req_ver=2.12 -fi +glib_req_ver=2.22 glib_modules=gthread-2.0 if test "$modules" = yes; then glib_modules="$glib_modules gmodule-2.0"
Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- configure | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)