| Message ID | 1425376508-12632-1-git-send-email-zhang.zhanghailiang@huawei.com |
|---|---|
| State | New |
| Headers | show |
On 03/03/2015 02:55 AM, zhanghailiang wrote: > Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > --- Might have been nice to mention this was a continuation of the work started in commit 565f65d27. > hw/arm/virt.c | 2 +- > savevm.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
Eric Blake <eblake@redhat.com> writes: > On 03/03/2015 02:55 AM, zhanghailiang wrote: >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >> --- > > Might have been nice to mention this was a continuation of the work > started in commit 565f65d27. Yes. Perhaps the -trivial maintainer can stick in a reference on commit. >> hw/arm/virt.c | 2 +- >> savevm.c | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > Reviewed-by: Eric Blake <eblake@redhat.com>
On 2015/3/4 1:18, Eric Blake wrote: > On 03/03/2015 02:55 AM, zhanghailiang wrote: >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >> --- > > Might have been nice to mention this was a continuation of the work > started in commit 565f65d27. > OK, will send v2 with this message added, Thanks. >> hw/arm/virt.c | 2 +- >> savevm.c | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > Reviewed-by: Eric Blake <eblake@redhat.com> >
On 2015/3/4 15:14, Markus Armbruster wrote: > Eric Blake <eblake@redhat.com> writes: > >> On 03/03/2015 02:55 AM, zhanghailiang wrote: >>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >>> --- >> >> Might have been nice to mention this was a continuation of the work >> started in commit 565f65d27. > > Yes. Perhaps the -trivial maintainer can stick in a reference on > commit. > :), i will send v2, to make his life easy. Thanks. >>> hw/arm/virt.c | 2 +- >>> savevm.c | 3 +-- >>> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> Reviewed-by: Eric Blake <eblake@redhat.com> > >
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 69f51ac..4732c12 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -768,7 +768,7 @@ static void machvirt_init(MachineState *machine) /* Handle any CPU options specified by the user */ cc->parse_features(CPU(cpuobj), cpustr[1], &err); if (err) { - error_report("%s", error_get_pretty(err)); + error_report_err(err); exit(1); } diff --git a/savevm.c b/savevm.c index ce2b6a2..c4f8c39 100644 --- a/savevm.c +++ b/savevm.c @@ -932,8 +932,7 @@ int qemu_loadvm_state(QEMUFile *f) int ret; if (qemu_savevm_state_blocked(&local_err)) { - error_report("%s", error_get_pretty(local_err)); - error_free(local_err); + error_report_err(local_err); return -EINVAL; }
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> --- hw/arm/virt.c | 2 +- savevm.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)