diff mbox

spapr: fix potential segfault due to uninitialized Error*

Message ID 1424999652-14539-1-git-send-email-mdroth@linux.vnet.ibm.com
State New
Headers show

Commit Message

Michael Roth Feb. 27, 2015, 1:14 a.m. UTC 
Introduced by 361f93e.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 hw/ppc/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Armbruster Feb. 27, 2015, 7:31 a.m. UTC | #1 
Michael Roth <mdroth@linux.vnet.ibm.com> writes:

> Introduced by 361f93e.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Since it hasn't been merged into master: can we still squash this into
my broken commit?
Alexander Graf Feb. 27, 2015, 3:26 p.m. UTC | #2 
On 27.02.15 08:31, Markus Armbruster wrote:
> Michael Roth <mdroth@linux.vnet.ibm.com> writes:
> 
>> Introduced by 361f93e.
>>
>> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 
> Since it hasn't been merged into master: can we still squash this into
> my broken commit?
> 

Thanks, squashed into the broken commit.


Alex
diff mbox

Patch

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index e1e66f2..2152704 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -111,7 +111,7 @@  sPAPREnvironment *spapr;
 static XICSState *try_create_xics(const char *type, int nr_servers,
                                   int nr_irqs, Error **errp)
 {
-    Error *err;
+    Error *err = NULL;
     DeviceState *dev;
 
     dev = qdev_create(NULL, type);