Message ID | 1422455690-13950-2-git-send-email-imammedo@redhat.com |
---|---|
State | New |
Headers | show |
On Wed, Jan 28, 2015 at 02:34:46PM +0000, Igor Mammedov wrote: > zero initialize AcpiPmInfo struct to reduce code bloat > a little bit. > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com> > Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Pls drop this, I prefer consistent initialization. > --- > hw/i386/acpi-build.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 4944249..6f8d4e3 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -172,6 +172,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) > Object *obj = NULL; > QObject *o; > > + memset(pm, 0, sizeof(*pm)); > + > if (piix) { > obj = piix; > } > @@ -184,22 +186,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) > o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL); > if (o) { > pm->s3_disabled = qint_get_int(qobject_to_qint(o)); > - } else { > - pm->s3_disabled = false; > } > qobject_decref(o); > o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL); > if (o) { > pm->s4_disabled = qint_get_int(qobject_to_qint(o)); > - } else { > - pm->s4_disabled = false; > } > qobject_decref(o); > o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL); > if (o) { > pm->s4_val = qint_get_int(qobject_to_qint(o)); > - } else { > - pm->s4_val = false; > } > qobject_decref(o); > > -- > 1.8.3.1
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4944249..6f8d4e3 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -172,6 +172,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) Object *obj = NULL; QObject *o; + memset(pm, 0, sizeof(*pm)); + if (piix) { obj = piix; } @@ -184,22 +186,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL); if (o) { pm->s3_disabled = qint_get_int(qobject_to_qint(o)); - } else { - pm->s3_disabled = false; } qobject_decref(o); o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL); if (o) { pm->s4_disabled = qint_get_int(qobject_to_qint(o)); - } else { - pm->s4_disabled = false; } qobject_decref(o); o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL); if (o) { pm->s4_val = qint_get_int(qobject_to_qint(o)); - } else { - pm->s4_val = false; } qobject_decref(o);