From patchwork Mon Nov 17 05:49:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: lijun X-Patchwork-Id: 411413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E274114010C for ; Mon, 17 Nov 2014 16:50:25 +1100 (AEDT) Received: from localhost ([::1]:46305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqFCf-000716-7u for incoming@patchwork.ozlabs.org; Mon, 17 Nov 2014 00:50:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqFCF-0006g1-7g for qemu-devel@nongnu.org; Mon, 17 Nov 2014 00:50:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqFC6-0007yn-5t for qemu-devel@nongnu.org; Mon, 17 Nov 2014 00:49:55 -0500 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:51391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqFC5-0007yi-Td for qemu-devel@nongnu.org; Mon, 17 Nov 2014 00:49:46 -0500 Received: by mail-pa0-f43.google.com with SMTP id kx10so1326676pab.30 for ; Sun, 16 Nov 2014 21:49:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=mZ1AlaVsLNuaHJwM1eghvZ0yILHN+IqyNrSh5ScBAo4=; b=mHecom8aV8XLlO6Xm+e22PIvOK5il3Xfpw0Va0pjW4gHCQTAtJJSYL3fi410QaKtHW kXXTLJQau27351KKZlKYqFZW3hV9uFWfAXzZLcBXbfQLiv1H1OC3rVMxpT/YWnJp+kDo Mwg0Hh2Hrb7PDhkk0v57j6dBN+5afRmgiyWnmDwDP6oUDnzMbyb7mf3L3FHBoaYS4oJ8 zTow7HhBGhD3eZS8ts6AWQmnWPvj8KGmmvBRExO31BlhMzHB2q+T6kraGFqJ9Mj6QsYk jn2F69r1qaSLJWAVOaXyTUBkLtSucw4jQLE8dHYsK0Sw1PfOEC+hSLZpkn7V7Ha08nF4 mIug== X-Received: by 10.68.57.200 with SMTP id k8mr27164329pbq.96.1416203384105; Sun, 16 Nov 2014 21:49:44 -0800 (PST) Received: from localhost ([203.114.244.88]) by mx.google.com with ESMTPSA id mt6sm33842035pbb.45.2014.11.16.21.49.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2014 21:49:43 -0800 (PST) From: Jun Li To: qemu-devel@nongnu.org Date: Mon, 17 Nov 2014 13:49:35 +0800 Message-Id: <1416203375-8185-1-git-send-email-junmuzi@gmail.com> X-Mailer: git-send-email 1.9.3 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22b Cc: famz@redhat.com, juli@redhat.com, kraxel@redhat.com, Jun Li Subject: [Qemu-devel] [PATCH] usb: delete error_report() for usb-bot X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When no device under usb-bot bus, usb_msd_handle_data() will print "usb-msd: Bad LUN 0". This is not correct hints. So delete error_report here. When scsi_device_find() return NULL, just goto fail. This patch fixes following bug. https://bugzilla.redhat.com/show_bug.cgi?id=1164665 Signed-off-by: Jun Li --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 4539733..f386d62 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -424,7 +424,6 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p) DPRINTF("Command on LUN %d\n", cbw.lun); scsi_dev = scsi_device_find(&s->bus, 0, 0, cbw.lun); if (scsi_dev == NULL) { - error_report("usb-msd: Bad LUN %d", cbw.lun); goto fail; } tag = le32_to_cpu(cbw.tag);