diff mbox

[1/2] raw-posix: Fix comment for raw_co_get_block_status()

Message ID 1415820422-17796-2-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster Nov. 12, 2014, 7:27 p.m. UTC
Missed in commit 705be72.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 block/raw-posix.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Eric Blake Nov. 12, 2014, 11:18 p.m. UTC | #1
On 11/12/2014 01:27 PM, Markus Armbruster wrote:
> Missed in commit 705be72.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  block/raw-posix.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index e100ae2..706d3c0 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1555,9 +1555,7 @@ static int try_seek_hole(BlockDriverState *bs, off_t start, off_t *data,
>  }
>  
>  /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the allocation status of the specified sectors.
>   *
>   * If 'sector_num' is beyond the end of the disk image the return value is 0
>   * and 'pnum' is set to 0.
>
Fam Zheng Nov. 13, 2014, 1:46 a.m. UTC | #2
On Wed, 11/12 20:27, Markus Armbruster wrote:
> Missed in commit 705be72.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  block/raw-posix.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index e100ae2..706d3c0 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1555,9 +1555,7 @@ static int try_seek_hole(BlockDriverState *bs, off_t start, off_t *data,
>  }
>  
>  /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the allocation status of the specified sectors.
>   *
>   * If 'sector_num' is beyond the end of the disk image the return value is 0
>   * and 'pnum' is set to 0.
> -- 
> 1.9.3
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>
Max Reitz Nov. 13, 2014, 8:39 a.m. UTC | #3
On 2014-11-12 at 20:27, Markus Armbruster wrote:
> Missed in commit 705be72.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   block/raw-posix.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index e100ae2..706d3c0 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1555,9 +1555,7 @@ static int try_seek_hole(BlockDriverState *bs, off_t start, off_t *data,
>   }
>   
>   /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the allocation status of the specified sectors.
>    *
>    * If 'sector_num' is beyond the end of the disk image the return value is 0
>    * and 'pnum' is set to 0.

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox

Patch

diff --git a/block/raw-posix.c b/block/raw-posix.c
index e100ae2..706d3c0 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1555,9 +1555,7 @@  static int try_seek_hole(BlockDriverState *bs, off_t start, off_t *data,
 }
 
 /*
- * Returns true iff the specified sector is present in the disk image. Drivers
- * not implementing the functionality are assumed to not support backing files,
- * hence all their sectors are reported as allocated.
+ * Returns the allocation status of the specified sectors.
  *
  * If 'sector_num' is beyond the end of the disk image the return value is 0
  * and 'pnum' is set to 0.