| Message ID | 1415791795-6779-1-git-send-email-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 12/11/2014 12:29, Fam Zheng wrote: > The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading > comment. > > Suggested-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > include/hw/virtio/virtio-scsi.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h > index 9e1a49c..bf17cc9 100644 > --- a/include/hw/virtio/virtio-scsi.h > +++ b/include/hw/virtio/virtio-scsi.h > @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq { > /* Note: > * - fields before elem are initialized by virtio_scsi_init_req; > * - elem is uninitialized at the time of allocation. > - * - fields after elem are zeroed by virtio_scsi_init_req. > + * - fields after elem (except the ending cdb[]) are zeroed by > + * virtio_scsi_init_req. > * */ > > VirtQueueElement elem; > Applied, thanks. Paolo
diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index 9e1a49c..bf17cc9 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq { /* Note: * - fields before elem are initialized by virtio_scsi_init_req; * - elem is uninitialized at the time of allocation. - * - fields after elem are zeroed by virtio_scsi_init_req. + * - fields after elem (except the ending cdb[]) are zeroed by + * virtio_scsi_init_req. * */ VirtQueueElement elem;
The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading comment. Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Fam Zheng <famz@redhat.com> --- include/hw/virtio/virtio-scsi.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)