From patchwork Tue Nov 11 12:39:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 409419 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 702691400E2 for ; Tue, 11 Nov 2014 23:41:26 +1100 (AEDT) Received: from localhost ([::1]:48181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoAlA-0000Oi-KQ for incoming@patchwork.ozlabs.org; Tue, 11 Nov 2014 07:41:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoAjW-0007SH-3T for qemu-devel@nongnu.org; Tue, 11 Nov 2014 07:39:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoAjL-0003mq-KT for qemu-devel@nongnu.org; Tue, 11 Nov 2014 07:39:41 -0500 Received: from mail-qc0-x22d.google.com ([2607:f8b0:400d:c01::22d]:37618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoAjL-0003ml-F8 for qemu-devel@nongnu.org; Tue, 11 Nov 2014 07:39:31 -0500 Received: by mail-qc0-f173.google.com with SMTP id x3so7260548qcv.4 for ; Tue, 11 Nov 2014 04:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=ecuuL4rkQE3+rMSm0GbT510+qjxCK3mp//7jCgwT1zQ=; b=AMjcGNXG4n6dCa28T7b8pD+r5MvP5jnjesmcQrenwHgeT9A9emtzTzWq5OW7LsSs2s 1yny+YJcGxlHqYFsUFQovH1SgbWzueupXoShDKJcqIVK4sXiAdo/TdGDmtDxXfscsrG9 nBUGS9SxHM2CjVqaPydDDLDagcWdJE0p7kQbPMDbrpkIV0OthAUTYDJUiH9VDrGSu9tK zMr9drAxMXV8EhJDC2PZqlsRhEXDl+mn4mhsWMBFDeLRd85W32uQeTDJDG4mfz8RSNaA AsUwUgd4apg4ghI6WaN+jA0x8GptEx/gwpR8H3evBYKU7ajbXFj39GodlnPeyCgZzO7y tmOw== X-Received: by 10.224.131.135 with SMTP id x7mr52635796qas.38.1415709569335; Tue, 11 Nov 2014 04:39:29 -0800 (PST) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by mx.google.com with ESMTPSA id a12sm18162328qai.1.2014.11.11.04.39.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Nov 2014 04:39:28 -0800 (PST) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 11 Nov 2014 13:39:19 +0100 Message-Id: <1415709559-2011-1-git-send-email-marcandre.lureau@gmail.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::22d Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , kraxel@redhat.com Subject: [Qemu-devel] [PATCH] spice: do not require TCP ports X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It is possible to use Spice server without TCP port. On local VM, qemu (and libvirt) can add new clients thanks to QMP add_client command. Signed-off-by: Marc-André Lureau --- ui/spice-core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 6467fa4..e8d4bae 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -661,10 +661,6 @@ void qemu_spice_init(void) } port = qemu_opt_get_number(opts, "port", 0); tls_port = qemu_opt_get_number(opts, "tls-port", 0); - if (!port && !tls_port) { - error_report("neither port nor tls-port specified for spice"); - exit(1); - } if (port < 0 || port > 65535) { error_report("spice port is out of range"); exit(1);