| Message ID | 1415698679-4264-1-git-send-email-arei.gonglei@huawei.com |
|---|---|
| State | New |
| Headers | show |
<arei.gonglei@huawei.com> writes: > From: Gonglei <arei.gonglei@huawei.com> > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > --- > include/hw/sysbus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h > index 6175bf9..d1f3f00 100644 > --- a/include/hw/sysbus.h > +++ b/include/hw/sysbus.h > @@ -10,7 +10,7 @@ > #define QDEV_MAX_PIO 32 > > #define TYPE_SYSTEM_BUS "System" > -#define SYSTEM_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS) > +#define SYSTEM_BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_SYSTEM_BUS) > > typedef struct SysBusDevice SysBusDevice; Has never been used, so this is "only" an unexploded landmine. Hope it's the only one of this kind. Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Subject: Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines > > <arei.gonglei@huawei.com> writes: > > > From: Gonglei <arei.gonglei@huawei.com> > > > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > > --- > > include/hw/sysbus.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h > > index 6175bf9..d1f3f00 100644 > > --- a/include/hw/sysbus.h > > +++ b/include/hw/sysbus.h > > @@ -10,7 +10,7 @@ > > #define QDEV_MAX_PIO 32 > > > > #define TYPE_SYSTEM_BUS "System" > > -#define SYSTEM_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS) > > +#define SYSTEM_BUS(obj) OBJECT_CHECK(BusState, (obj), > TYPE_SYSTEM_BUS) > > > > typedef struct SysBusDevice SysBusDevice; > > Has never been used, so this is "only" an unexploded landmine. Hope > it's the only one of this kind. > Yes, indeed. > Reviewed-by: Markus Armbruster <armbru@redhat.com> Thanks. :) Best regards, -Gonglei
A nice one. Applied to -trivial, thank you! /mjt
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 6175bf9..d1f3f00 100644 --- a/include/hw/sysbus.h +++ b/include/hw/sysbus.h @@ -10,7 +10,7 @@ #define QDEV_MAX_PIO 32 #define TYPE_SYSTEM_BUS "System" -#define SYSTEM_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS) +#define SYSTEM_BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_SYSTEM_BUS) typedef struct SysBusDevice SysBusDevice;