From patchwork Mon Nov 10 05:54:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeokYeon Hwang X-Patchwork-Id: 408674 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id F17EF140179 for ; Mon, 10 Nov 2014 16:55:53 +1100 (AEDT) Received: from localhost ([::1]:41044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnhx8-0004Jz-DZ for incoming@patchwork.ozlabs.org; Mon, 10 Nov 2014 00:55:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnhwh-00041M-SX for qemu-devel@nongnu.org; Mon, 10 Nov 2014 00:55:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnhwa-00067e-MS for qemu-devel@nongnu.org; Mon, 10 Nov 2014 00:55:23 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:40970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnhwa-00067N-CQ for qemu-devel@nongnu.org; Mon, 10 Nov 2014 00:55:16 -0500 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NET0055X73Z5DE0@mailout1.samsung.com> for qemu-devel@nongnu.org; Mon, 10 Nov 2014 14:55:11 +0900 (KST) X-AuditID: cbfee61b-f79d76d0000024d6-5a-5460533f71dd Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 09.1C.09430.F3350645; Mon, 10 Nov 2014 14:55:11 +0900 (KST) Received: from localhost.localdomain ([182.198.1.3]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NET002LC73YHG20@mmp1.samsung.com>; Mon, 10 Nov 2014 14:55:10 +0900 (KST) From: SeokYeon Hwang To: qemu-devel@nongnu.org Date: Mon, 10 Nov 2014 14:54:49 +0900 Message-id: <1415598889-11244-1-git-send-email-syeon.hwang@samsung.com> X-Mailer: git-send-email 2.1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOJMWRmVeSWpSXmKPExsVy+t9jAV374IQQg4Mv2C3mr73PYjHx7XpW i0mdV9gs5t1Stph0bCqbxfHeHSwWN9afZnNg99g56y67x5Nrm5k83u+7yubRt2UVYwBLFJdN SmpOZllqkb5dAlfGh3Mz2Qs+cVT07FFvYPzG1sXIySEhYCLxcvILdghbTOLCvfVAcS4OIYFF jBJ7ZuxjgXBamCTO/73PBFLFJqAnsWHZAUYQW0RAUuJ312lmkCJmgZmMEq1nesBGCQt4SzQ9 uAlmswioSiw9Ox+smVfAXeLg7L3MEOvkJDbs/s84gZF7ASPDKkbR1ILkguKk9FwjveLE3OLS vHS95PzcTYzg4HgmvYNxVYPFIUYBDkYlHl6Ht/EhQqyJZcWVuYcYJTiYlUR4a/8DhXhTEiur Uovy44tKc1KLDzFKc7AoifMebLUOFBJITyxJzU5NLUgtgskycXBKNTBOu2q37ZaSx/1Lp5nt 33ycGqRw79LTnfambsI9qd8MfqatWVdvFS0ooRn1q3jvHd1JHh5LdptHsWU+72hdcSg+efU1 heTKpeIHbSbpsWyJ5RYXW73ljqFj8FlGN+Y3jO9ObdKq/NOs/VjyhMFyTVejKRN5g66JTxNq On5g+Z3P0w/s3f3q/HkLJZbijERDLeai4kQA06NoiAoCAAA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 203.254.224.24 Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, armbru@redhat.com, mreitz@redhat.com, SeokYeon Hwang Subject: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Added 'assert(os_errno > 0)' in 'error_set_errno()'. Fixed errno since it passes wrong value to 'error_set_errno()'. Signed-off-by: SeokYeon Hwang Reviewed-by: Amos Kong Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster --- hw/pci/pcie.c | 2 +- util/error.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev, /* the slot is electromechanically locked. * This error is propagated up to qdev and then to HMP/QMP. */ - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked"); + error_setg_errno(errp, EBUSY, "slot is electromechanically locked"); } } diff --git a/util/error.c b/util/error.c index 2ace0d8..6c9d995 100644 --- a/util/error.c +++ b/util/error.c @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, return; } assert(*errp == NULL); + assert(os_errno >= 0); err = g_malloc0(sizeof(*err));