diff mbox

[v2,RESEND,3/4] qapi-schema: Add version info for transaction types

Message ID 1414979247-11194-4-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Nov. 3, 2014, 1:47 a.m. UTC
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 qapi-schema.json | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Blake Nov. 4, 2014, 4:27 p.m. UTC | #1
On 11/03/2014 02:47 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  qapi-schema.json | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 1ddd395..48ba583 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1256,6 +1256,8 @@
>  # @transaction.
>  #
>  # Since 1.1
> +# drive-backup since 1.6
> +# blockdev-snapshot-internal-sync since 1.7
>  # blockdev-backup since 2.3

Aha - you (almost) addressed my comment from 2/4 - you missed that abort
was also added in 1.6, alongside drive-backup.

I'd be okay if you squashed this in with 2/4.
diff mbox

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 1ddd395..48ba583 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1256,6 +1256,8 @@ 
 # @transaction.
 #
 # Since 1.1
+# drive-backup since 1.6
+# blockdev-snapshot-internal-sync since 1.7
 # blockdev-backup since 2.3
 ##
 { 'union': 'TransactionAction',