diff mbox

[v2] Modify qemu_opt_rename to realize renaming all items in opts

Message ID 1411537527-16715-1-git-send-email-junmuzi@gmail.com
State New
Headers show

Commit Message

lijun Sept. 24, 2014, 5:45 a.m. UTC 
Add realization of rename all items in opts for qemu_opt_rename.
e.g:
When add bps twice in command line, need to rename all bps to
throttling.bps-total.

This patch solved following bug:
Bug 1145586 - qemu-kvm will give strange hint when add bps twice for a drive
ref:https://bugzilla.redhat.com/show_bug.cgi?id=1145586

Signed-off-by: Jun Li <junmuzi@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 blockdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/blockdev.c b/blockdev.c
index b361fbb..ed95b76 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -536,8 +536,8 @@  static void qemu_opt_rename(QemuOpts *opts, const char *from, const char *to)
 {
     const char *value;
 
-    value = qemu_opt_get(opts, from);
-    if (value) {
+    /* rename all items in opts */
+    while ((value = qemu_opt_get(opts, from))) {
         qemu_opt_set(opts, to, value);
         qemu_opt_unset(opts, from);
     }