diff mbox

[v3,16/23] pc87312: Drop unused members of PC87312State

Message ID 1410891148-28849-17-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster Sept. 16, 2014, 6:12 p.m. UTC 
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 include/hw/isa/pc87312.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Benoît Canet Sept. 17, 2014, 11:44 a.m. UTC | #1 
On Tue, Sep 16, 2014 at 08:12:21PM +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/hw/isa/pc87312.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h
> index befc8bd..bf74470 100644
> --- a/include/hw/isa/pc87312.h
> +++ b/include/hw/isa/pc87312.h
> @@ -47,13 +47,10 @@ typedef struct PC87312State {
>  
>      struct {
>          ISADevice *dev;
> -        BlockDriverState *drive[2];
> -        uint32_t base;
>      } fdc;
>  
>      struct {
>          ISADevice *dev;
> -        uint32_t base;
>      } ide;
>  
>      MemoryRegion io;
> -- 
> 1.9.3
> 
Reviewed-by: Benoit Canet <benoit.canet@nodalink.com>
Max Reitz Sept. 20, 2014, 10:07 p.m. UTC | #2 
On 16.09.2014 20:12, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   include/hw/isa/pc87312.h | 3 ---
>   1 file changed, 3 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>
Kevin Wolf Sept. 29, 2014, 12:08 p.m. UTC | #3 
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>
diff mbox

Patch

diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h
index befc8bd..bf74470 100644
--- a/include/hw/isa/pc87312.h
+++ b/include/hw/isa/pc87312.h
@@ -47,13 +47,10 @@  typedef struct PC87312State {
 
     struct {
         ISADevice *dev;
-        BlockDriverState *drive[2];
-        uint32_t base;
     } fdc;
 
     struct {
         ISADevice *dev;
-        uint32_t base;
     } ide;
 
     MemoryRegion io;