From patchwork Wed Aug 27 08:09:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Chen X-Patchwork-Id: 383377 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0EF11140093 for ; Wed, 27 Aug 2014 18:16:43 +1000 (EST) Received: from localhost ([::1]:58186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMYPJ-0005ns-6F for incoming@patchwork.ozlabs.org; Wed, 27 Aug 2014 04:16:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMYHo-0002jp-W2 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 04:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMYHn-00031f-MT for qemu-devel@nongnu.org; Wed, 27 Aug 2014 04:08:56 -0400 Received: from [59.151.112.132] (port=58300 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMYHn-000310-30 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 04:08:55 -0400 X-IronPort-AV: E=Sophos;i="5.04,409,1406563200"; d="scan'208";a="35133140" Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Aug 2014 16:05:59 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id s7R88mHV000505; Wed, 27 Aug 2014 16:08:51 +0800 Received: from tangchen.fnst.cn.fujitsu.com (10.167.226.71) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.181.6; Wed, 27 Aug 2014 16:08:56 +0800 From: Tang Chen To: , , , Date: Wed, 27 Aug 2014 16:09:45 +0800 Message-ID: <1409126988-22287-2-git-send-email-tangchen@cn.fujitsu.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1409126988-22287-1-git-send-email-tangchen@cn.fujitsu.com> References: <1409126988-22287-1-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.226.71] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Cc: hutao@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, zhugh.fnst@cn.fujitsu.com, tangchen@cn.fujitsu.com Subject: [Qemu-devel] [RFC PATCH v1 1/4] Use macro to define ACPI notification event. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org According to ACPI spec, device object notification values define insertion request (Device Check) as 1, and ejection request as 3. Use macro to define them. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 7 +++++-- include/hw/acpi/acpi.h | 5 ++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index f29715a..1b21191 100644 --- a/hw/acpi/memory_hotplug.c +++ b/hw/acpi/memory_hotplug.c @@ -155,10 +155,13 @@ static void acpi_memory_hotplug_write(void *opaque, hwaddr addr, uint64_t data, break; case 0x4: /* _OST event */ mdev = &mem_st->devs[mem_st->selector]; - if (data == 1) { + switch (data) { + case ACPI_NOTIFY_DEVICE_CHECK: /* TODO: handle device insert OST event */ - } else if (data == 3) { + break; + case ACPI_NOTIFY_EJECT_REQUEST: /* TODO: handle device remove OST event */ + break; } mdev->ost_event = data; trace_mhp_acpi_write_ost_ev(mem_st->selector, mdev->ost_event); diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index e105e45..e8499f6 100644 --- a/include/hw/acpi/acpi.h +++ b/include/hw/acpi/acpi.h @@ -92,9 +92,12 @@ #define ACPI_BITMASK_ARB_DISABLE 0x0001 /* OST_EVENT */ -#define ACPI_NOTIFY_EJECT_REQUEST 0x03 #define ACPI_OSPM_EJECT 0x103 +/* NOTIFY_EVENT */ +#define ACPI_NOTIFY_DEVICE_CHECK 0x1 +#define ACPI_NOTIFY_EJECT_REQUEST 0x3 + /* OST_STATUS */ #define ACPI_SUCCESS 0x0 #define ACPI_FAILURE 0x1