diff mbox

[V2,08/12] linux-user: Detect fault in sched_rr_get_interval

Message ID 1407869623-11185-9-git-send-email-tommusta@gmail.com
State New
Headers show

Commit Message

Tom Musta Aug. 12, 2014, 6:53 p.m. UTC 
Properly detect a fault when attempting to store into an invalid
struct timespec pointer.

Signed-off-by: Tom Musta <tommusta@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
V2: Peter has observed that there are other call sites that may need to
be fixed.  I will address that in future patch(es).

 linux-user/syscall.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

David Gibson Aug. 26, 2014, 12:44 a.m. UTC | #1 
On Tue, Aug 12, 2014 at 01:53:39PM -0500, Tom Musta wrote:
> Properly detect a fault when attempting to store into an invalid
> struct timespec pointer.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
diff mbox

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 49b8a07..a20c2f7 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7760,7 +7760,7 @@  abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
             struct timespec ts;
             ret = get_errno(sched_rr_get_interval(arg1, &ts));
             if (!is_error(ret)) {
-                host_to_target_timespec(arg2, &ts);
+                ret = host_to_target_timespec(arg2, &ts);
             }
         }
         break;