diff mbox

vscclient: Add required headers to fix build on FreeBSD

Message ID 1403096280-68774-1-git-send-email-emaste@freebsd.org
State New
Headers show

Commit Message

Ed Maste June 18, 2014, 12:58 p.m. UTC 
Signed-off-by: Ed Maste <emaste@freebsd.org>
---
 libcacard/vscclient.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Paolo Bonzini June 18, 2014, 2:41 p.m. UTC | #1 
Il 18/06/2014 14:58, Ed Maste ha scritto:
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
>  libcacard/vscclient.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
> index ab9b2b8..80111df 100644
> --- a/libcacard/vscclient.c
> +++ b/libcacard/vscclient.c
> @@ -11,6 +11,8 @@
>   */
>
>  #ifndef _WIN32
> +#include <sys/socket.h>
> +#include <netinet/in.h>
>  #include <netdb.h>
>  #define closesocket(x) close(x)
>  #endif
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Andreas Färber June 18, 2014, 3:22 p.m. UTC | #2 
Am 18.06.2014 16:41, schrieb Paolo Bonzini:
> Il 18/06/2014 14:58, Ed Maste ha scritto:
>> Signed-off-by: Ed Maste <emaste@freebsd.org>
>> ---
>>  libcacard/vscclient.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
>> index ab9b2b8..80111df 100644
>> --- a/libcacard/vscclient.c
>> +++ b/libcacard/vscclient.c
>> @@ -11,6 +11,8 @@
>>   */
>>
>>  #ifndef _WIN32
>> +#include <sys/socket.h>
>> +#include <netinet/in.h>
>>  #include <netdb.h>
>>  #define closesocket(x) close(x)
>>  #endif
>>
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Looks okay, CC'ing Alon and -trivial.

Andreas
Ed Maste June 20, 2014, 8:38 p.m. UTC | #3 
On 18 June 2014 11:22, Andreas Färber <afaerber@suse.de> wrote:
> Am 18.06.2014 16:41, schrieb Paolo Bonzini:
>> Il 18/06/2014 14:58, Ed Maste ha scritto:
>>> Signed-off-by: Ed Maste <emaste@freebsd.org>
>>> ---
>>>  libcacard/vscclient.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
>>> index ab9b2b8..80111df 100644
>>> --- a/libcacard/vscclient.c
>>> +++ b/libcacard/vscclient.c
>>> @@ -11,6 +11,8 @@
>>>   */
>>>
>>>  #ifndef _WIN32
>>> +#include <sys/socket.h>
>>> +#include <netinet/in.h>
>>>  #include <netdb.h>
>>>  #define closesocket(x) close(x)
>>>  #endif
>>>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Looks okay, CC'ing Alon and -trivial.

Ping - can we bring in this build fix other than by waiting on -trivial?
Michael Tokarev June 21, 2014, 12:48 p.m. UTC | #4 
Applied to -trivial, thank you!

/mjt
diff mbox

Patch

diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index ab9b2b8..80111df 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -11,6 +11,8 @@ 
  */
 
 #ifndef _WIN32
+#include <sys/socket.h>
+#include <netinet/in.h>
 #include <netdb.h>
 #define closesocket(x) close(x)
 #endif