diff mbox

[v4,1/3] qapi: fix coding style in parameters list

Message ID 1399511680-12811-2-git-send-email-akong@redhat.com
State New
Headers show

Commit Message

Amos Kong May 8, 2014, 1:14 a.m. UTC 
The space before pointers is redundant.

Signed-off-by: Amos Kong <akong@redhat.com>
---
 scripts/qapi-visit.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Eric Blake May 13, 2014, 2:57 a.m. UTC | #1 
On 05/07/2014 07:14 PM, Amos Kong wrote:
> The space before pointers is redundant.
> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  scripts/qapi-visit.py | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

<rant>
Appears to be unchanged from v2.  Missing the Reviewed-by I gave on v2
for the code, and you were even reminded about that in v3.  I suggested
a better wording for the commit message in v2:

A space after * when declaring a pointer type is redundant.

but that still hasn't been done.  It's frustrating when review comments
are not addressed (even if you don't want to make a particular change,
at least document why keeping things unchanged is preferable, rather
than silently ignoring the review).
</rant>

That said, the change is still correct, so it still deserves:

Reviewed-by: Eric Blake <eblake@redhat.com>
Amos Kong May 21, 2014, 2:08 a.m. UTC | #2 
On Mon, May 12, 2014 at 08:57:30PM -0600, Eric Blake wrote:
> On 05/07/2014 07:14 PM, Amos Kong wrote:
> > The space before pointers is redundant.
> > 
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> >  scripts/qapi-visit.py | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> <rant>
> Appears to be unchanged from v2.  Missing the Reviewed-by I gave on v2
> for the code, and you were even reminded about that in v3.  I suggested
> a better wording for the commit message in v2:
> 
> A space after * when declaring a pointer type is redundant.
> 
> but that still hasn't been done.  It's frustrating when review comments
> are not addressed (even if you don't want to make a particular change,
> at least document why keeping things unchanged is preferable, rather
> than silently ignoring the review).
> </rant>

Sorry about the careless.
 
> That said, the change is still correct, so it still deserves:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
 
Thanks for your patience of the new review-by.

> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
diff mbox

Patch

diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index c6579be..25834e3 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -38,7 +38,7 @@  def generate_visit_struct_fields(name, field_prefix, fn_prefix, members, base =
 
     ret += mcgen('''
 
-static void visit_type_%(full_name)s_fields(Visitor *m, %(name)s ** obj, Error **errp)
+static void visit_type_%(full_name)s_fields(Visitor *m, %(name)s **obj, Error **errp)
 {
     Error *err = NULL;
 ''',
@@ -149,7 +149,7 @@  def generate_visit_struct(expr):
 
     ret += mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)
+void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error **errp)
 {
 ''',
                 name=name)
@@ -166,7 +166,7 @@  void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **
 def generate_visit_list(name, members):
     return mcgen('''
 
-void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name, Error **errp)
+void visit_type_%(name)sList(Visitor *m, %(name)sList **obj, const char *name, Error **errp)
 {
     GenericList *i, **prev = (GenericList **)obj;
     Error *err = NULL;
@@ -193,7 +193,7 @@  void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name,
 def generate_visit_enum(name, members):
     return mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error **errp)
+void visit_type_%(name)s(Visitor *m, %(name)s *obj, const char *name, Error **errp)
 {
     visit_type_enum(m, (int *)obj, %(name)s_lookup, "%(name)s", name, errp);
 }
@@ -203,7 +203,7 @@  void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error **e
 def generate_visit_anon_union(name, members):
     ret = mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)
+void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error **errp)
 {
     Error *err = NULL;
 
@@ -279,7 +279,7 @@  def generate_visit_union(expr):
 
     ret += mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)
+void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error **errp)
 {
     Error *err = NULL;
 
@@ -367,13 +367,13 @@  def generate_declaration(name, members, genlist=True, builtin_type=False):
     if not builtin_type:
         ret += mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp);
+void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error **errp);
 ''',
                     name=name)
 
     if genlist:
         ret += mcgen('''
-void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name, Error **errp);
+void visit_type_%(name)sList(Visitor *m, %(name)sList **obj, const char *name, Error **errp);
 ''',
                  name=name)
 
@@ -383,7 +383,7 @@  def generate_enum_declaration(name, members, genlist=True):
     ret = ""
     if genlist:
         ret += mcgen('''
-void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name, Error **errp);
+void visit_type_%(name)sList(Visitor *m, %(name)sList **obj, const char *name, Error **errp);
 ''',
                      name=name)
 
@@ -392,7 +392,7 @@  void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name,
 def generate_decl_enum(name, members, genlist=True):
     return mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error **errp);
+void visit_type_%(name)s(Visitor *m, %(name)s *obj, const char *name, Error **errp);
 ''',
                 name=name)