diff mbox

qemu-file: use fwrite() correctly (take II)

Message ID 1394046523-16983-1-git-send-email-quintela@redhat.com
State New
Headers show

Commit Message

Juan Quintela March 5, 2014, 7:08 p.m. UTC 
Simple minds like mine can't understand neither fwrite, or comments
when there are 3 versions of a patch.  The integrated patch is missing
this bit.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---

I added Reviewed-by: by Eric & Markus because they acked the version
with this change in.

 qemu-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Blake March 5, 2014, 7:27 p.m. UTC | #1 
On 03/05/2014 12:08 PM, Juan Quintela wrote:
> Simple minds like mine can't understand neither fwrite, or comments
> when there are 3 versions of a patch.  The integrated patch is missing
> this bit.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
> 
> I added Reviewed-by: by Eric & Markus because they acked the version
> with this change in.

Also posted here:
https://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04902.html

but indeed, we want this patch in sooner rather than later, since
misapplied patches can be a nightmare to track down later (such as in
backporting efforts).
diff mbox

Patch

diff --git a/qemu-file.c b/qemu-file.c
index f074af1..e5ec798 100644
--- a/qemu-file.c
+++ b/qemu-file.c
@@ -105,7 +105,7 @@  static int stdio_put_buffer(void *opaque, const uint8_t *buf, int64_t pos,
     res = fwrite(buf, 1, size, s->stdio_file);

     if (res != size) {
-        return -EIO;	/* fake errno value */
+        return -errno;
     }
     return res;
 }